Revisit Block Structure #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the unsuccessful test runs (in both cases) boil down to a single failing test: the flaky one from #100. |
Specifically: replace public scripts (hashes) and inputs with public announcements. Closes #40.
So: populate proof with empty vec.
- Add debug print statements in test. - In some mutator set method, turn `unwrap` into `unwrap_or_else` with `panic!` in order to display debug info.
Problem was using `block_digest` instead of `tip_digest` to lookup the tip header. Co-authored-by: Thorkil Værge <[email protected]>
aszepieniec
force-pushed
the
alphanet-v6
branch
from
18b526f to
f4bce56
Compare
The block header does not need to commit to the block body. It is a potential source of discrepancy and at best surplus weight. Note that the block header does not commit to the body. However, the proof-of-work puzzle is defined in terms of the *block's hash*, which is `H(H(header)||H(body))`, so the *pair* is committed to when the miner expends energy.
The mutator set is already present in the block. Keeping its hash in the header constitutes duplicate representation of data and is a source of potential discrepancy. Moreover, it was not used anywhere, as far as I can tell.
Sword-Smith
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Excellent breakdown of the validity logic. I look forward to working with these traits SecretWitness and ValidationLogic. Also great that the block hash is not stored or transferred but always calculated.
I think we can avoid the manual implementation of discriminant. If the variants do not carry data, you can just cast the values to usize. I would keep the HasDiscriminant trait though as it's nice to have a uniform way of getting the discriminants for these field selectors.
For enums without associated data (as used here), casting to usize gives the discriminant. This commit switches to that as it is less prone to error, but keeps the `.discriminant()` interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Blockdata structureNote that (some of) these changes are not backwards-compatible, meaning that this essentially corresponds to a new alphanet release.