Default disable email service with note in docs explaining rationale #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
NeonDaniel
added a commit
that referenced
this pull request
Feb 27, 2024
# Changelog ## [0.0.1a9](https://github.com/NeonGeckoCom/neon-hana/tree/0.0.1a9) (2024-02-26) [Full Changelog](0.0.1a8...0.0.1a9) **Merged pull requests:** - Cleanup comments and prep for release [\#13](#13) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.0.1a8](https://github.com/NeonGeckoCom/neon-hana/tree/0.0.1a8) (2024-01-26) [Full Changelog](0.0.1a7...0.0.1a8) **Merged pull requests:** - Update to use client-provided public IP address when available [\#12](#12) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.0.1a7](https://github.com/NeonGeckoCom/neon-hana/tree/0.0.1a7) (2024-01-26) [Full Changelog](0.0.1a6...0.0.1a7) **Merged pull requests:** - Add Node data model and Session support [\#11](#11) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.0.1a6](https://github.com/NeonGeckoCom/neon-hana/tree/0.0.1a6) (2024-01-26) [Full Changelog](0.0.1a5...0.0.1a6) **Merged pull requests:** - Configurable Authorization Request Limits [\#9](#9) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.0.1a5](https://github.com/NeonGeckoCom/neon-hana/tree/0.0.1a5) (2024-01-23) [Full Changelog](0.0.1a4...0.0.1a5) **Merged pull requests:** - JWT server cache fix and client response update [\#8](#8) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.0.1a4](https://github.com/NeonGeckoCom/neon-hana/tree/0.0.1a4) (2024-01-22) [Full Changelog](0.0.1a3...0.0.1a4) **Merged pull requests:** - Default disable email service with note in docs explaining rationale [\#4](#4) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.0.1a3](https://github.com/NeonGeckoCom/neon-hana/tree/0.0.1a3) (2024-01-22) [Full Changelog](0.0.1a2...0.0.1a3) **Merged pull requests:** - Add `assist` route for HTTP requests [\#3](#3) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.0.1a2](https://github.com/NeonGeckoCom/neon-hana/tree/0.0.1a2) (2024-01-19) [Full Changelog](885ec6e...0.0.1a2) **Merged pull requests:** - Fix path errors in test build automation [\#2](#2) ([NeonDaniel](https://github.com/NeonDaniel)) - Initial Implementation [\#1](#1) ([NeonDaniel](https://github.com/NeonDaniel)) \* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds an option to disable the email service because anyone with access to the API would be able to send an email from the configured email address with any attachments/email contents
Issues
Other Notes
The email proxy service should do some kind of validation of email contents to prevent abuse, but it must allow for skills to reasonably use the email service. Consider also imposing stricter rate limits as emails are sent infrequently under normal circumstances