Implement FastAPI Unit Tests #34
Open
+573
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add default value handling to `request.client` params to address test failures Add httpx test dependency for FastAPI tests
Fix errors in LLMResponse example
Make IP address lookups in util module safe
mikejgray
approved these changes
Nov 18, 2024
| client_manager.validate_auth("", request.client.host) | ||
| return request.client.host | ||
| ip_addr = request.client.host if request.client else "127.0.0.1" | ||
| if len(ip_addr.split('.')) != 4: |
There was a problem hiding this comment.
nit(non-blocking): There is an outside chance a hostname could have multiple subdomains and end up triggering this conditional. Might be worth using regex, but this won't make or break the PR IMHO
| @@ -1,4 +1,5 @@ | |||
| pytest | |||
| mock | |||
| httpx | |||
There was a problem hiding this comment.
I didn't see this used - was it an initial implementation but removed later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds test coverage for all exposed endpoints with mocked backend methods
Addresses some edge-case bugs in
request.clientobject handlingFixes/completes model type annotations
Issues
Other Notes