Implement streaming audio Websocket #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outline handling of client audio stream
Lazy init streaming when clients connect to the endpoint TODO note client cleanup upon disconnection
…dio support Update mocked methods for compat with dinkum 0.1.0+ Add websocket dependencies for streaming client Add apt dependencies to Dockerfile for Python module builds
Separate streaming dependencies from basic WS Refactor streaming client code into a separate module
Handle streaming socket retry if too early Implement streaming audio responses
Remove duplicate docstring not included in OpanAPI pages
Update docstring to note undocumented functionality may change
mikejgray
approved these changes
Oct 8, 2024
Comment on lines
+58
to
+59
| stt=Mock(transcribe=Mock(return_value=[])), | ||
| fallback_stt=Mock(transcribe=Mock(return_value=[])), |
There was a problem hiding this comment.
Consider MagicMock, which should stub out all of the necessary methods without having to be explicit
There was a problem hiding this comment.
Looks like the inferred return type is not a list if I use MagicMock (similar issue with transformers return value)
│ Exception in thread Thread-6: │
│ Traceback (most recent call last): │
│ File "/usr/local/lib/python3.9/threading.py", line 980, in _bootstrap_inner │
│ self.run() │
│ File "/usr/local/lib/python3.9/site-packages/neon_hana/streaming_client.py", line 67, in run │
│ self.voice_loop.run() │
│ File "/usr/local/lib/python3.9/site-packages/ovos_dinkum_listener/voice_loop/voice_loop.py", line 269, in run │
│ self._after_cmd(chunk) │
│ File "/usr/local/lib/python3.9/site-packages/ovos_dinkum_listener/voice_loop/voice_loop.py", line 783, in _after_cmd │
│ utts, stt_context = self._get_tx(stt_context) │
│ File "/usr/local/lib/python3.9/site-packages/ovos_dinkum_listener/voice_loop/voice_loop.py", line 731, in _get_tx │
│ filtered = [max(utts, key=lambda k: k[1])] │
│ ValueError: max() arg is an empty sequence
There was a problem hiding this comment.
You can set a return type to anything you'd like with a MagicMock, but this is definitely not blocking:
Python 3.12.6 (main, Sep 6 2024, 19:03:47) [Clang 15.0.0 (clang-1500.3.9.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from unittest.mock import MagicMock
>>>
>>> # Create a mock transcription result
>>> mock_transcription = [("Hello, this is a test", 0.9)]
>>>
>>> # Set up the STT objects using MagicMock
>>> stt = MagicMock()
>>> stt.transcribe.return_value = mock_transcription
>>>
>>> fallback_stt = MagicMock()
>>> fallback_stt.transcribe.return_value = mock_transcription
>>> stt.transcribe
<MagicMock name='mock.transcribe' id='4314005728'>
>>> stt.transcribe()
[('Hello, this is a test', 0.9)]
>>> fallback_stt.transcribe()
[('Hello, this is a test', 0.9)]
>>> type(fallback_stt.transcribe())
<class 'list'>
>>> [max(stt.transcribe(), key=lambda k: k[1])]
[('Hello, this is a test', 0.9)]There was a problem hiding this comment.
I see. 6 of one half dozen of the other IMO since we're explicitly specifying those methods and their return values
Add locking around session changes
mikejgray
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a WS API for streaming raw audio (input and output) with a per-client listener running in the backend
Issues
Other Notes