Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and use setcoeff! for arb poly rings #1916

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

lgoettgens
Copy link
Collaborator

The former dispatch for ZZRingElem used a non-existing flint function. I rewrote the setcoeff!s using flintify to dispatch to all possible flint functions.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 87.46%. Comparing base (06ec014) to head (6775ff3).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/arb/ComplexPoly.jl 57.14% 3 Missing ⚠️
src/arb/RealPoly.jl 57.14% 3 Missing ⚠️
src/arb/acb_poly.jl 57.14% 3 Missing ⚠️
src/arb/arb_poly.jl 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1916      +/-   ##
==========================================
+ Coverage   87.39%   87.46%   +0.06%     
==========================================
  Files          97       97              
  Lines       35614    35626      +12     
==========================================
+ Hits        31124    31159      +35     
+ Misses       4490     4467      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens changed the title Fix and use setcoeff! for antic poly rings Fix and use setcoeff! for arb poly rings Oct 23, 2024
@fingolfin
Copy link
Member

Unfortunately this has conflicts now :-(

@fingolfin fingolfin merged commit 9df1993 into Nemocas:master Oct 28, 2024
23 of 24 checks passed
@lgoettgens lgoettgens deleted the lg/less-ccalls-setcoeff branch October 28, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants