Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type of PublicCode #800

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Type of PublicCode #800

merged 1 commit into from
Nov 19, 2024

Conversation

trurlurl
Copy link
Collaborator

All PublicCode elements should be of type PublicCodeStructure, LinePublicCode probably as well.

@trurlurl trurlurl added bug Technical mistake, inconsistency with the documentation, etc. needs documentation update The NeTEx document needs to be updated labels Nov 18, 2024
@trurlurl trurlurl added this to the netex_2.0 milestone Nov 18, 2024
ue71603
ue71603 previously approved these changes Nov 18, 2024
View reviewed changes
@skinkie
Copy link
Contributor

skinkie commented Nov 19, 2024

For fixes target master.

@skinkie skinkie changed the base branch from next to master November 19, 2024 01:12
@skinkie skinkie dismissed ue71603’s stale review November 19, 2024 01:12

The base branch was changed.

@skinkie skinkie changed the base branch from master to next November 19, 2024 01:12
skinkie
skinkie requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@skinkie skinkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redo on master.

@skinkie
Copy link
Contributor

skinkie commented Nov 19, 2024

@ue71603 needs cherry pick. I'll do it shortly.

skinkie added a commit that referenced this pull request Nov 19, 2024
@skinkie
Do the same as #800 but then on master
ad72787
@skinkie skinkie merged commit 315f33c into next Nov 19, 2024
1 check passed
@skinkie skinkie deleted the public_code_type_and_other_bugs branch November 19, 2024 10:22
@trurlurl trurlurl mentioned this pull request Nov 19, 2024
Closed
@trurlurl trurlurl added document has been updated NeTEx Document already updated and removed needs documentation update The NeTEx document needs to be updated labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ue71603 ue71603 ue71603 approved these changes

@skinkie skinkie skinkie approved these changes

@Aurige Aurige Awaiting requested review from Aurige

Assignees
No one assigned
Labels
bug Technical mistake, inconsistency with the documentation, etc. document has been updated NeTEx Document already updated
Projects
None yet
Milestone
netex_2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@trurlurl @skinkie @ue71603