Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 No Shadows on MacOS for Transparent Windows #328

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nickhudkins
Copy link

@nickhudkins nickhudkins commented Sep 12, 2024

While we discuss if notan should expose a means by which to obtain a raw_window_handle, we'll piggyback on transparency as a proxy for "please don't show shadows".

While this changes existing behavior, it might actually be what folks expect?

@Nazariglez
Copy link
Owner

Hey @nickhudkins, thanks for the PRs!

Is exposing raw_window_handle intended to disable the shadows? I think this change should ideally be handled by winit rather than directly in Notan, and it may already be available in winit.

Winit has changed a lot in recent releases, and Notan isn’t fully up to date with those changes yet. Updating Notan to the latest versions of Winit could be complex. I’m currently working on a new version that incorporates the latest Winit, but it will introduce some breaking changes in Notan as well. I’m not sure whether we want to wait for that update or not.

Mind if I ask why you need this feature? Feel free to skip the question if it's not relevant.

I’ll review the PR for exposing the raw window handle soon — that could be a good solution for your case if you're in a rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants