First steps in adding Silicon Labs CIP-51 to the 8051 language files #7320

gtackett · 2024-12-26T19:15:03Z

Added a variant called CIP-51 to 8051.ldefs, and for this variant specifically:
- Added a commented-out compiler entry for Keil Cx51 compilers, to be un-commented out once cx51.cspec is complete
- Pending possible removal of Archimedes C compiler entry, commented it out, Archimedes having been acquired over 20 years ago by Keil. (See 8051 language files trivia #5878)
In 8051_main.sinc added internal flash address space and expanded SFR address space, both conditionalized on CIP51,
Began work on cx51.cspec towards implementing Keil's Cx51 calling convention.

…h addrress space and extend SFR address space to two byte. Conditionalized definition of SFR space so that CIP51 gets 2 bytes (Intel MCS51 uses 1 byte) and add IFLASH address space to CIP51.

Retains for now the 8051 "default" compiler, adding a "stub" (that is, commented-out) compiler definition for Keil Cx51 and commenting out (preparatory to eventually deleting) the line for the Archimedes compiler that Keil bought out and obsoleted.

…nto language_files

For CIP-51 follow convention of lower-case filenames While I was at it, normalized indentation of "manualindexfile" items.

Abide by lowercase filename convention. Make the slafile name match the name of this variant. Make this version 1.0 of the cip-51 language.

Removed SFRs not in CIP-51, renamed several holdovers from 8051, added comment annotations to SFRs on Page 0 and on All Pages.

Still need to compare to what I have at home

jobermayr · 2025-01-20T21:41:02Z

First certification.manifest must be updated:

+data/languages/cip-51.pspec||GHIDRA||||END|
+data/languages/keil-cx51.cspec||GHIDRA||||END|

Then it leads to a runtime error:
Validation error: Missing sleigh file:
.../Ghidra/Processors/8051/data/languages/cip-51.slaspec which should be fixed with:

diff --git a/Ghidra/Processors/8051/data/languages/cip-51.slaspec b/Ghidra/Processors/8051/data/languages/cip-51.slaspec
new file mode 100644
index 0000000000..522a9f419d
--- /dev/null
+++ b/Ghidra/Processors/8051/data/languages/cip-51.slaspec
@@ -0,0 +1,3 @@
+@define CIP51  ""
+
+@include "8051_main.sinc"

But this leads to a build error:

Compiling ./data/languages/cip-51.slaspec:
unknown variable: GROUP1 at 8051_main.sinc:660(662): :ACALL  Addr11 is  $(GROUP1) & aaddrfill=1 & aoplo=1 & Addr11   { ret:2 = inst_next; push16(ret); call Addr11; }
Errors during preprocessing, halting compilation

@jobermayr

Per github comment by @jobermayr, added cip-51.pspec and keil-cx51.cspec

Add CIP51 to conditional that determines definition of GROUP1, GROUP2, GROUP3

Need to add cip-51.slaspec as well

@jobermayr

@jobermayr pointed out this missing file in original PR

gtackett · 2025-01-21T18:24:17Z

First certification.manifest must be updated:

+data/languages/cip-51.pspec||GHIDRA||||END|
+data/languages/keil-cx51.cspec||GHIDRA||||END|

Then it leads to a runtime error: Validation error: Missing sleigh file: .../Ghidra/Processors/8051/data/languages/cip-51.slaspec which should be fixed with:

diff --git a/Ghidra/Processors/8051/data/languages/cip-51.slaspec b/Ghidra/Processors/8051/data/languages/cip-51.slaspec
new file mode 100644
index 0000000000..522a9f419d
--- /dev/null
+++ b/Ghidra/Processors/8051/data/languages/cip-51.slaspec
@@ -0,0 +1,3 @@
+@define CIP51  ""
+
+@include "8051_main.sinc"

But this leads to a build error:

Compiling ./data/languages/cip-51.slaspec:
unknown variable: GROUP1 at 8051_main.sinc:660(662): :ACALL  Addr11 is  $(GROUP1) & aaddrfill=1 & aoplo=1 & Addr11   { ret:2 = inst_next; push16(ret); call Addr11; }
Errors during preprocessing, halting compilation

Made changes via github.com that I believe should resolve these. Also added cip-51.slaspec tp certification.manifest.
However, I don't have a way to test with these changes while at work, and when I get home today, my time is probably spoken for.

I appreciate your input, @jobermayr

jobermayr · 2025-01-23T00:57:08Z

New build error:

Compiling ./data/languages/cip-51.slaspec:
8051_main.sinc:517: unknown start, end, next2, operand, epsilon, or varnode 'ACC' in varnode reference
Unrecoverable error(s), halting compilation
java.lang.NullPointerException: Cannot invoke "ghidra.pcodeCPort.slghsymbol.SpecificSymbol.getVarnode()" because "ss" is null
        at ghidra.sleigh.grammar.SleighCompiler.varnode(SleighCompiler.java:9439)
        at ghidra.sleigh.grammar.SleighCompiler.export(SleighCompiler.java:7842)
        at ghidra.sleigh.grammar.SleighCompiler.statement(SleighCompiler.java:6153)
        at ghidra.sleigh.grammar.SleighCompiler.statements(SleighCompiler.java:5896)
        at ghidra.sleigh.grammar.SleighCompiler.code_block(SleighCompiler.java:5843)
        at ghidra.sleigh.grammar.SleighCompiler.semantic(SleighCompiler.java:5753)
        at ghidra.sleigh.grammar.SleighCompiler.ctorsemantic(SleighCompiler.java:3609)
        at ghidra.sleigh.grammar.SleighCompiler.constructor(SleighCompiler.java:3519)
        at ghidra.sleigh.grammar.SleighCompiler.constructorlike(SleighCompiler.java:3070)
        at ghidra.sleigh.grammar.SleighCompiler.root(SleighCompiler.java:486)
        at ghidra.pcodeCPort.slgh_compile.SleighCompile.run_compilation(SleighCompile.java:1854)
        at ghidra.pcodeCPort.slgh_compile.SleighCompileLauncher.runMain(SleighCompileLauncher.java:217)
        at ghidra.pcodeCPort.slgh_compile.SleighCompile.main(SleighCompile.java:1910)

…idra into language_files

…top PCODE

gtackett · 2025-02-05T12:56:53Z

I believe these changes have already been merged

jobermayr · 2025-02-05T13:13:45Z

I believe these changes have already been merged

No: https://github.com/NationalSecurityAgency/ghidra/commits/master/Ghidra/Processors/8051

gtackett added 6 commits December 12, 2024 12:58

Changes to 8051_main.sinc for Silicon Labs CIP51 to add internal flas…

ccde8b5

…h addrress space and extend SFR address space to two byte. Conditionalized definition of SFR space so that CIP51 gets 2 bytes (Intel MCS51 uses 1 byte) and add IFLASH address space to CIP51.

Merge branch 'NationalSecurityAgency:master' into language_files

22d4d57

Add Keil Cx51 compiler support

3bb53e2

Merge branch 'language_files' of https://github.com/gtackett/ghidra i…

ec21340

…nto language_files

Add Keil Cx51 compiler spec

2309fe9

ryanmkurtz self-assigned this Jan 5, 2025

ryanmkurtz added Status: Prioritize This is currently being prioritized Feature: Processor/8051 labels Jan 5, 2025

gtackett added 7 commits January 9, 2025 15:16

Update 8051.ldefs

0f589b4

For CIP-51 follow convention of lower-case filenames While I was at it, normalized indentation of "manualindexfile" items.

Update cip-51 variant in 8051.ldefs

41f1e4e

Abide by lowercase filename convention. Make the slafile name match the name of this variant. Make this version 1.0 of the cip-51 language.

Merge branch 'NationalSecurityAgency:master' into language_files

855483f

Update 8051.ldefs to change "Keil" to "ARM Keil"

f94553a

Create cip-51.pspec (empty at this point)

b66ed15

Update cip-51.pspec

7528a6b

Removed SFRs not in CIP-51, renamed several holdovers from 8051, added comment annotations to SFRs on Page 0 and on All Pages.

Merged keil-cx51.cspec with changes from work

f56dd7b

Still need to compare to what I have at home

ryanmkurtz assigned emteere and unassigned ryanmkurtz Jan 16, 2025

ryanmkurtz added Status: Triage Information is being gathered Status: Internal This is being tracked internally by the Ghidra team and removed Status: Prioritize This is currently being prioritized Status: Triage Information is being gathered labels Jan 16, 2025

gtackett added 5 commits January 21, 2025 12:55

Update certification.manifest

628fe32

Per github comment by @jobermayr, added cip-51.pspec and keil-cx51.cspec

Merge branch 'NationalSecurityAgency:master' into language_files

c8cea15

Update 8051_main.sinc

c8606d7

Add CIP51 to conditional that determines definition of GROUP1, GROUP2, GROUP3

Update certification.manifest

135b9d2

Need to add cip-51.slaspec as well

Create cip-51.slaspec

8bb0431

@jobermayr pointed out this missing file in original PR

Merge branch 'NationalSecurityAgency:master' into language_files

fe28f85

gtackett added 2 commits January 24, 2025 08:08

Merge branch 'master' of https://github.com/NationalSecurityAgency/gh…

d0e75e4

…idra into language_files

Fix keil-cx51.cspec: correct register sizes, remove LCALL, fix segmen…

f4832b0

…top PCODE

gtackett closed this Feb 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First steps in adding Silicon Labs CIP-51 to the 8051 language files #7320

First steps in adding Silicon Labs CIP-51 to the 8051 language files #7320

gtackett commented Dec 26, 2024 •

edited

Loading

jobermayr commented Jan 20, 2025

gtackett commented Jan 21, 2025

jobermayr commented Jan 23, 2025

gtackett commented Feb 5, 2025

jobermayr commented Feb 5, 2025

First steps in adding Silicon Labs CIP-51 to the 8051 language files #7320

First steps in adding Silicon Labs CIP-51 to the 8051 language files #7320

Conversation

gtackett commented Dec 26, 2024 • edited Loading

jobermayr commented Jan 20, 2025

gtackett commented Jan 21, 2025

jobermayr commented Jan 23, 2025

gtackett commented Feb 5, 2025

jobermayr commented Feb 5, 2025

gtackett commented Dec 26, 2024 •

edited

Loading