Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding @Nullable to BaseDataObject tld to remove warning #1046

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

sambish5
Copy link
Collaborator

@sambish5 sambish5 commented Jan 16, 2025

Done to remove this warning on build:

[INFO] Recompiling the module because of changed source code.
[INFO] Compiling 411 source files with javac [forked debug release 11] to target/classes
[WARNING] /emissary/src/main/java/emissary/core/BaseDataObject.java:[243,14] [FieldMissingNullable] Field is assigned (or compared against) a definitely null value but is not annotated @Nullable
    (see https://errorprone.info/bugpattern/FieldMissingNullable)
  Did you mean '@Nullable protected final IBaseDataObject tld;'?
[WARNING] /emissary/src/main/java/emissary/core/BaseDataObject.java:[257,14] [FieldMissingNullable] Field is assigned (or compared against) a definitely null value but is not annotated @Nullable
    (see https://errorprone.info/bugpattern/FieldMissingNullable)
  Did you mean '@Nullable protected final IBaseDataObject tld;'?

@sambish5 sambish5 added the tech-debt Low-impact cleanup and upkeep label Jan 16, 2025
@jpdahlke jpdahlke added this to the v8.21.0 milestone Jan 16, 2025
@jpdahlke jpdahlke merged commit 59155fd into NationalSecurityAgency:main Jan 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Low-impact cleanup and upkeep
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants