bug :: preserve original behavior for getStringParameter and return n…

…ull not an empty string
NationalSecurityAgency · Dec 27, 2024 · 0033170 · 0033170
1 parent 2f072d9
commit 0033170
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/emissary/core/BaseDataObject.java b/src/main/java/emissary/core/BaseDataObject.java
@@ -972,7 +972,7 @@ public String getParameterAsString(final String key) {
         if (obj.size() > 1) {
             logger.warn("Multiple values for parameter, returning the first - parameter:{}, number of values:{}", key, obj.size());
         }
-        return StringUtils.trimToNull(obj.stream().findFirst().orElse(null));
+        return obj.stream().findFirst().orElse(null);
     }
 
     /**

diff --git a/src/test/java/emissary/core/BaseDataObjectTest.java b/src/test/java/emissary/core/BaseDataObjectTest.java
@@ -1370,7 +1370,7 @@ void testGetParameterAsString() throws IOException {
         assertNull(this.b.getParameterAsConcatString("A"));
 
         this.b.putParameter("A", "");
-        assertNull(this.b.getParameterAsString("A"));
+        assertEquals("", this.b.getParameterAsString("A"));
         assertEquals("", this.b.getParameterAsConcatString("A"));
 
         assertNull(this.b.getParameterAsString("DNE"));