-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge submodules #2654
Open
ivakegg
wants to merge
46
commits into
integration
Choose a base branch
from
merge-submodules
base: integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Merge submodules #2654
Changes from 38 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
1f96d1a
git subrepo clone [email protected]:NationalSecurityAgency/datawave-type…
ivakegg c5ed797
git subrepo clone [email protected]:NationalSecurityAgency/datawave-util…
ivakegg 342deba
git subrepo clone [email protected]:NationalSecurityAgency/datawave-base…
ivakegg ed41c73
git subrepo clone [email protected]:NationalSecurityAgency/datawave-in-m…
ivakegg 6f03263
git subrepo clone [email protected]:NationalSecurityAgency/datawave-metr…
ivakegg 10f3c6c
git subrepo clone [email protected]:NationalSecurityAgency/datawave-accu…
ivakegg 88f9ea3
git subrepo clone (merge) [email protected]:NationalSecurityAgency/dataw…
ivakegg 5006bea
git subrepo clone (merge) [email protected]:NationalSecurityAgency/dataw…
ivakegg 4632c3c
git subrepo clone [email protected]:NationalSecurityAgency/datawave-pare…
ivakegg 037d4b0
git subrepo clone [email protected]:NationalSecurityAgency/datawave-serv…
ivakegg a4e7047
git subrepo clone (merge) [email protected]:NationalSecurityAgency/dataw…
ivakegg 495a494
git subrepo clone (merge) [email protected]:NationalSecurityAgency/dataw…
ivakegg c5861a0
git subrepo clone (merge) [email protected]:NationalSecurityAgency/dataw…
ivakegg 97d7ba1
git subrepo clone (merge) [email protected]:NationalSecurityAgency/dataw…
ivakegg 4207b81
git subrepo clone [email protected]:NationalSecurityAgency/datawave-dict…
ivakegg 4197425
git subrepo clone [email protected]:NationalSecurityAgency/datawave-file…
ivakegg a998ec6
git subrepo clone (merge) [email protected]:NationalSecurityAgency/dataw…
ivakegg 84118fe
git subrepo clone [email protected]:NationalSecurityAgency/datawave-map-…
ivakegg 9c4cb96
git subrepo clone (merge) [email protected]:NationalSecurityAgency/dataw…
ivakegg 5de15ca
git subrepo clone (merge) [email protected]:NationalSecurityAgency/dataw…
ivakegg 28f4951
git subrepo clone [email protected]:NationalSecurityAgency/datawave-quer…
ivakegg 5b0f7db
git subrepo clone (merge) [email protected]:NationalSecurityAgency/dataw…
ivakegg f153b52
git subrepo clone [email protected]:NationalSecurityAgency/datawave-quer…
ivakegg 3c95341
git subrepo clone (merge) [email protected]:NationalSecurityAgency/dataw…
ivakegg aeef6cc
git subrepo clone [email protected]:NationalSecurityAgency/datawave-spri…
ivakegg 6f42aab
git subrepo clone (merge) [email protected]:NationalSecurityAgency/dataw…
ivakegg 8ec75c0
git subrepo clone (merge) [email protected]:NationalSecurityAgency/dataw…
ivakegg 16261fb
git subrepo clone (merge) [email protected]:NationalSecurityAgency/dataw…
ivakegg ea39a27
git subrepo clone (merge) [email protected]:NationalSecurityAgency/dataw…
ivakegg a9278cd
git subrepo clone (merge) [email protected]:NationalSecurityAgency/dataw…
ivakegg c868816
Updated profiles to optionally add former submodules into build/test
ivakegg aac3eb4
git subrepo pull core/utils/metadata-utils
ivakegg 21470e7
Updated other readme files that mention submodules
ivakegg 95b22f7
Merge branch 'integration' into merge-submodules
ivakegg f147983
Merge branch 'integration' into merge-submodules
alerman e8032dd
Merge remote-tracking branch 'origin/integration' into merge-submodules
ivakegg 4bc062f
git subrepo pull core/utils/metadata-utils
ivakegg cde0b9c
Updated per review comments
ivakegg 58675fe
Merge branch 'integration' into merge-submodules
ivakegg 3396eec
git subrepo pull (merge) microservices/services/accumulo
ivakegg 931d801
git subrepo pull (merge) microservices/services/query-metric
ivakegg 8917b1b
Added try logic to start zk server
ivakegg 38fa2d1
Use random port for zk server
ivakegg 300fa36
Upped the timeout for the split brain testing
ivakegg a4ae6a4
Attempt to diagnose failing test case
ivakegg 48730f2
Working on fixing periodically failing tests
ivakegg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,90 +0,0 @@ | ||
[submodule "microservices/services/authorization"] | ||
path = microservices/services/authorization | ||
url = [email protected]:NationalSecurityAgency/datawave-authorization-service.git | ||
[submodule "core/in-memory-accumulo"] | ||
path = core/in-memory-accumulo | ||
url = [email protected]:NationalSecurityAgency/datawave-in-memory-accumulo.git | ||
[submodule "core/utils/accumulo-utils"] | ||
path = core/utils/accumulo-utils | ||
url = [email protected]:NationalSecurityAgency/datawave-accumulo-utils.git | ||
[submodule "core/utils/common-utils"] | ||
path = core/utils/common-utils | ||
url = [email protected]:NationalSecurityAgency/datawave-common-utils.git | ||
[submodule "core/base-rest-responses"] | ||
path = core/base-rest-responses | ||
url = [email protected]:NationalSecurityAgency/datawave-base-rest-responses.git | ||
[submodule "core/utils/type-utils"] | ||
path = core/utils/type-utils | ||
url = [email protected]:NationalSecurityAgency/datawave-type-utils.git | ||
[submodule "core/utils/metadata-utils"] | ||
path = core/utils/metadata-utils | ||
url = [email protected]:NationalSecurityAgency/datawave-metadata-utils.git | ||
[submodule "microservices/services/accumulo"] | ||
path = microservices/services/accumulo | ||
url = [email protected]:NationalSecurityAgency/datawave-accumulo-service.git | ||
[submodule "microservices/services/dictionary"] | ||
path = microservices/services/dictionary | ||
url = [email protected]:NationalSecurityAgency/datawave-dictionary-service.git | ||
[submodule "microservices/services/audit"] | ||
path = microservices/services/audit | ||
url = [email protected]:NationalSecurityAgency/datawave-audit-service.git | ||
[submodule "microservices/services/query-metric"] | ||
path = microservices/services/query-metric | ||
url = [email protected]:NationalSecurityAgency/datawave-query-metric-service.git | ||
[submodule "core/metrics-reporter"] | ||
path = core/metrics-reporter | ||
url = [email protected]:NationalSecurityAgency/datawave-metrics-reporter.git | ||
[submodule "microservices/starters/cache"] | ||
path = microservices/starters/cache | ||
url = [email protected]:NationalSecurityAgency/datawave-spring-boot-starter-cache.git | ||
[submodule "microservices/starters/datawave"] | ||
path = microservices/starters/datawave | ||
url = [email protected]:NationalSecurityAgency/datawave-spring-boot-starter.git | ||
[submodule "microservices/services/hazelcast"] | ||
path = microservices/services/hazelcast | ||
url = [email protected]:NationalSecurityAgency/datawave-hazelcast-service.git | ||
[submodule "microservices/starters/metadata"] | ||
path = microservices/starters/metadata | ||
url = [email protected]:NationalSecurityAgency/datawave-spring-boot-starter-metadata.git | ||
[submodule "microservices/starters/query-metric"] | ||
path = microservices/starters/query-metric | ||
url = [email protected]:NationalSecurityAgency/datawave-spring-boot-starter-query-metric.git | ||
[submodule "microservices/starters/audit"] | ||
path = microservices/starters/audit | ||
url = [email protected]:NationalSecurityAgency/datawave-spring-boot-starter-audit.git | ||
[submodule "microservices/services/config"] | ||
path = microservices/services/config | ||
url = [email protected]:NationalSecurityAgency/datawave-config-service.git | ||
[submodule "microservices/microservice-parent"] | ||
path = microservices/microservice-parent | ||
url = [email protected]:NationalSecurityAgency/datawave-parent.git | ||
[submodule "microservices/microservice-service-parent"] | ||
path = microservices/microservice-service-parent | ||
url = [email protected]:NationalSecurityAgency/datawave-service-parent.git | ||
[submodule "contrib/datawave-utils"] | ||
path = contrib/datawave-utils | ||
url = [email protected]:NationalSecurityAgency/datawave-utils.git | ||
[submodule "microservices/starters/query"] | ||
path = microservices/starters/query | ||
url = [email protected]:NationalSecurityAgency/datawave-spring-boot-starter-query.git | ||
[submodule "microservices/services/query"] | ||
path = microservices/services/query | ||
url = [email protected]:NationalSecurityAgency/datawave-query-service.git | ||
[submodule "microservices/services/query-executor"] | ||
path = microservices/services/query-executor | ||
url = [email protected]:NationalSecurityAgency/datawave-query-executor-service.git | ||
[submodule "microservices/services/modification"] | ||
path = microservices/services/modification | ||
url = [email protected]:NationalSecurityAgency/datawave-modification-service.git | ||
[submodule "microservices/services/mapreduce-query"] | ||
path = microservices/services/mapreduce-query | ||
url = [email protected]:NationalSecurityAgency/datawave-mapreduce-query-service.git | ||
[submodule "microservices/starters/cached-results"] | ||
path = microservices/starters/cached-results | ||
url = [email protected]:NationalSecurityAgency/datawave-spring-boot-starter-cached-results.git | ||
[submodule "microservices/services/map"] | ||
path = microservices/services/map | ||
url = [email protected]:NationalSecurityAgency/datawave-map-service.git | ||
[submodule "microservices/services/file-provider"] | ||
path = microservices/services/file-provider | ||
url = [email protected]:NationalSecurityAgency/datawave-file-provider-service.git | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,42 +19,74 @@ Basic build instructions are [here](BUILDME.md) | |
|
||
## How to Use this Repository | ||
|
||
The microservices and associated utility projects are intended to be | ||
developed, versioned, and released independently and as such are stored | ||
in separate repositories. This repository includes them all as submodules | ||
in order to provide an easy way to import them all in an IDE for viewing | ||
the code, or refactoring. [Git submodules](https://git-scm.com/book/en/v2/Git-Tools-Submodules) | ||
require some extra commands over the normal ones that one may be familiar | ||
with. | ||
|
||
### Cloning with all submodules | ||
Cloning with all of the submodules is not required; however, if you are interested in checking | ||
out and building all of the datawave projects under one repo, read this! | ||
|
||
It's easiest to clone the repository pointing the submodules at the same branch | ||
```bash | ||
# Start out by cloning the project as you normally would. | ||
git clone [email protected]:NationalSecurityAgency/datawave.git | ||
|
||
# Now, use git to retrieve all of the datawave submodules. | ||
# This will leave your submodules in a detached head state. | ||
cd datawave | ||
git submodule update --init --recursive | ||
|
||
# You can checkout the main branch for each submodule so that you are no longer in a detached head state. | ||
# The addition of `|| :` will ensure that the command is executed for each submodule, | ||
# ignoring failures for submodules that don't have a main branch. | ||
git submodule foreach 'git checkout main || :' | ||
|
||
# It is recommended to build the project using multiple threads. | ||
mvn -Pdocker,dist clean install -T 1C | ||
The microservices and associated utility projects are intended to be developed, versioned, | ||
and released independently. The following subdirectories contain those independently | ||
versioned modules: | ||
|
||
``` | ||
core/utils/type-utils | ||
contrib/datawave-utils | ||
core/base-rest-responses | ||
core/in-memory-accumulo | ||
core/metrics-reporter | ||
core/utils/accumulo-utils | ||
core/utils/common-utils | ||
core/utils/metadata-utils | ||
microservices/microservice-parent | ||
microservices/microservice-service-parent | ||
microservices/starters/audit | ||
microservices/starters/cache | ||
microservices/starters/cached-results | ||
microservices/starters/datawave | ||
microservices/starters/metadata | ||
microservices/starters/query | ||
microservices/starters/query-metric | ||
microservices/services/accumulo | ||
microservices/services/audit | ||
microservices/services/authorization | ||
microservices/services/config | ||
microservices/services/dictionary | ||
microservices/services/file-provider | ||
microservices/services/hazelcast | ||
microservices/services/map | ||
microservices/services/mapreduce-query | ||
microservices/services/modification | ||
microservices/services/query | ||
microservices/services/query-executor | ||
microservices/services/query-metric | ||
``` | ||
|
||
# If you don't want to build the microservices, you can skip them. | ||
mvn -Pdocker,dist -DskipMicroservices clean install -T 1C | ||
Each of those subdirectories contain a .gitrepo file that keeps track of where the code came from. | ||
|
||
# If you decide that you no longer need the submodules, you can remove them. | ||
git submodule deinit --all | ||
### Updating one of the datawave sub-repositories | ||
At one point we used submodules to link in a all of the sub-repositories. We have now switched | ||
to including the submodules' code directly into the main datawave repository. The git subrepo | ||
mechanism (https://github.com/ingydotnet/git-subrepo) was used to facilitate the transition. | ||
That same mechanism can be used to pull in changes from the other repositories as needed until | ||
they can be removed altogether. The original cloning of the sub repositories was done using | ||
the subrepo command as follows: | ||
``` | ||
git subrepo clone <repo> <dir> | ||
``` | ||
If changes need to be pulled in, then the following process can be used: | ||
``` | ||
git subrepo pull <dir> | ||
``` | ||
### Building | ||
|
||
It is recommended to build the project using multiple threads. This will not build the starters, utilities, and services. | ||
``` | ||
mvn -Pdocker,dist clean install -T 1C | ||
``` | ||
|
||
If you want to build the starters, util modules, and services as well then try this | ||
``` | ||
mvn -Pdocker,dist -Dstarters -Dservices -Dutils clean install -T 1C | ||
ivakegg marked this conversation as resolved.
Show resolved
Hide resolved
|
||
``` | ||
If you want to build the service apis but not the services themselveds then add -DonlyServiceApis | ||
|
||
NOTE: The util modules, starters, and services are actually tagged and deployed separately. | ||
Hence the snapshot versions within those sub repos are not connected together. | ||
|
||
### DataWave Microservices | ||
|
||
|
Submodule datawave-utils
deleted from
4348fc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
target/ | ||
|
||
.idea/ | ||
*.iml | ||
*.iws | ||
|
||
.classpath | ||
.project | ||
.settings/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
; DO NOT EDIT (unless you know what you are doing) | ||
; | ||
; This subdirectory is a git "subrepo", and this file is maintained by the | ||
; git-subrepo command. See https://github.com/ingydotnet/git-subrepo#readme | ||
; | ||
[subrepo] | ||
remote = [email protected]:NationalSecurityAgency/datawave-utils.git | ||
branch = main | ||
commit = 4348fc36a3519ca9e5d1b96ac47c3f0b64abe34b | ||
parent = 1f96d1af84c45f32007da0105b8eab514ec3f7d3 | ||
method = merge | ||
cmdver = 0.4.9 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The job
compose-build-and-test-latest-snapshots
is still going through the submodules (although there's none) recursively and checking them out.It currently includes the following step:
But should be: