Fix erroneous LastUpdated timestamps appearing in data dictionary #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No unit test to validate the fix? |
Added a unit test in latest commit. Open to more feedback. |
apmoriarty
approved these changes
Aug 1, 2024
avgAGB
approved these changes
Aug 5, 2024
hlgp
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dictionary-service #32
Before this change there were instances where timestamps within the LastUpdated column of the data dictionary would appear as large values with a "+" in front of them.
Example:
After doing some digging, these timestamps were supposed to be pre-1970 dates. Which indicated an issue with negative epoch times was occurring. This section of code I removed was responsible for the incorrect timestamp.
Example after change:
