Allow table cache to be bypassed by ModelBean (#2359) #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-ratcliffe
force-pushed
the
feature/bypassTableCache
branch
4 times, most recently
from
98392a8 to
870b996
Compare
keith-ratcliffe
force-pushed
the
feature/bypassTableCache
branch
2 times, most recently
from
bfa7a1c to
1f39377
Compare
keith-ratcliffe
commented
May 23, 2024
| @@ -86,7 +90,7 @@ public class ModelBean { | |||
| private static final long BATCH_WRITER_MAX_MEMORY = 10845760; | |||
| private static final int BATCH_WRITER_MAX_THREADS = 2; | |||
|
|
|||
| private static final HashSet<String> RESERVED_COLF_VALUES = Sets.newHashSet("e", "i", "ri", "f", "tf", "m", "desc", "edge", "t", "n", "h"); | |||
| private static final HashSet<String> RESERVED_COLF_VALUES = Sets.newHashSet("e", "i", "ri", "f", "tf", "m", "desc", "edge", "t", "n", "h", "version"); | |||
There was a problem hiding this comment.
This fixes a preexisting bug: listModelNames method erroneously returns "version" (i.e., colf of the "edge_key" row) as an existing model
keith-ratcliffe
force-pushed
the
feature/bypassTableCache
branch
2 times, most recently
from
b2ad0db to
d61c1b6
Compare
keith-ratcliffe
added
bug
ivakegg
reviewed
May 29, 2024
web-services/model/src/main/java/datawave/webservice/query/model/ModelBean.java
Show resolved
Hide resolved
web-services/model/src/main/java/datawave/webservice/query/model/ModelBean.java
Outdated
Show resolved
Hide resolved
keith-ratcliffe
force-pushed
the
feature/bypassTableCache
branch
8 times, most recently
from
792c604 to
c2e9015
Compare
* Update accumulo-utils version
* Add ModelBean quickstart integration tests
* Address PR feedback:
Extend '/import' to enable update/replace semantics via
optional path parameter, i.e., '/import/{modelName}'
keith-ratcliffe
force-pushed
the
feature/bypassTableCache
branch
from
c2e9015 to
0eb3292
Compare
apmoriarty
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on NationalSecurityAgency/datawave-accumulo-utils#14
The goal here is to allow certain ModelBean operations to be performed in a more timely manner. E.g., in order to replace a given query model, the current implementation requires that a user first perform a model DELETE operation and then wait for an asynchronous cache refresh, so that the subsequent model import can succeed. If the cache isn't fully refreshed, the import fails with an error, because the deleted model is still resident in the stale cache. That process can be drastically streamlined by simply allowing the table cache to be bypassed by an "admin" user
This PR also fixes a bug in the
listModelNamesmethod that misidentifies row:edge_keycolf:versionas a query model