Skip to content

Commit

Permalink
review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ivakegg committed Oct 7, 2024
1 parent 4b00e53 commit 1653964
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@
public class LcNoDiacriticsNormalizer extends AbstractNormalizer<String> {
private static final long serialVersionUID = -7922074256473963293L;
private static final Pattern diacriticals = Pattern.compile("\\p{InCombiningDiacriticalMarks}");
private static final Pattern capitals = Pattern.compile("[A-Z]");


public String normalize(String fieldValue) {
if (null == fieldValue) {
return null;
Expand Down Expand Up @@ -57,7 +56,7 @@ public String normalizeRegex(String fieldRegex) {
@Override
public boolean normalizedRegexIsLossy(String regex) {
// Despite this normalizer actually being lossy, we are still
// returning false as users are used to overmathing when including
// returning false as users are used to overmatching when including
// diacritics or upper case letter. We may consider changing this
// down the road, but for not returning false.
return false;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/datawave/data/normalizer/LcNormalizer.java
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public String normalizeRegex(String fieldRegex) {
@Override
public boolean normalizedRegexIsLossy(String regex) {
// Despite this normalizer actually being lossy, we are still
// returning false as users are used to overmathing when including
// returning false as users are used to overmatching when including
// diacritics or upper case letter. We may consider changing this
// down the road, but for not returning false.
return false;
Expand Down

0 comments on commit 1653964

Please sign in to comment.