Replace Deprecated Calls #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivakegg
reviewed
Oct 2, 2024
| @@ -127,7 +128,7 @@ protected boolean principalChanged(HttpServletRequest request, Authentication cu | |||
| } | |||
|
|
|||
| protected List<SubjectIssuerDNPair> getSubjectIssuerDNPairs(String proxiedSubjects, String proxiedIssuers) { | |||
| if (StringUtils.isEmpty(proxiedSubjects)) { | |||
| if (ObjectUtils.isEmpty(proxiedSubjects)) { | |||
There was a problem hiding this comment.
Using this method has overhead as it has to do isInstanceOf checks. I would prefer to use !StringUtils.hasLength(proxiedSubjects)
ivakegg
reviewed
Oct 2, 2024
| ScheduledReporter reporter = factory.forRegistry(metricRegistry).convertRatesTo(TimeUnit.SECONDS).convertDurationsTo(TimeUnit.MILLISECONDS) | ||
| .build(configProps.getHost(), configProps.getPort()); | ||
| registerReporter(reporter).start(configProps.getInterval(), configProps.getIntervalUnit()); | ||
| } catch (InstantiationException | IllegalAccessException e) { | ||
| throw new RuntimeException("Unable to instantiate metrics reporter factory class " + configProps.getFactoryClass() + ": " + e.getMessage(), e); | ||
| } catch (InvocationTargetException e) { |
There was a problem hiding this comment.
I think you could have simply added these addition exceptions to the previous catch clause.
ivakegg
reviewed
Oct 2, 2024
| throw new HttpMessageNotReadableException("Unable to read protostuff message: " + e.getMessage(), e, inputMessage); | ||
| } catch (InvocationTargetException e) { |
There was a problem hiding this comment.
I would prefer adding this exception to the previous clause instead.
ivakegg
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace several straightforward deprecated calls with their suggested replacements.
part of NationalSecurityAgency/datawave#2443