Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for patterned model mappings #39

Merged
merged 9 commits into from
Nov 29, 2024
Merged

Conversation

lbschanno
Copy link
Collaborator

Support using patterns when building the forward model mappings for a query model.

Fixes #2429

Support using patterns when building the forward model mappings for a
query model.

Fixes #2429
@lbschanno lbschanno linked an issue Jun 26, 2024 that may be closed by this pull request
ivakegg
ivakegg previously approved these changes Jun 26, 2024
hlgp
hlgp previously approved these changes Jun 26, 2024
@lbschanno lbschanno dismissed stale reviews from hlgp and ivakegg via 12e4a14 July 2, 2024 18:23
@hlgp
Copy link
Collaborator

hlgp commented Nov 1, 2024

Looks good! Would love a corresponding Datawave Unit Test to verify the impact on Query.

@lbschanno
Copy link
Collaborator Author

@hlgp understood, I will work on adding a unit test to Datawave.

@lbschanno
Copy link
Collaborator Author

@hlgp I created a PR with the requested unit test here.

@ivakegg ivakegg merged commit 51f1307 into main Nov 29, 2024
2 checks passed
@ivakegg ivakegg deleted the feature/patternModelMapping branch November 29, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patterned model mappings
4 participants