MetadataHelper address try-with-resources warnings #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avgAGB
approved these changes
Jun 14, 2024
ivakegg
approved these changes
Jun 14, 2024
jwomeara
added a commit
that referenced
this pull request
Jun 26, 2024
commit 56a2269762b7ccd8986790aa9f0d235172ff3161 Author: Whitney O'Meara <[email protected]> Date: Wed Jun 26 20:40:33 2024 +0000 udpated type-utils version commit ab0098dbe86f2d15bf2a18c1b74dc22623183c30 Author: Whitney O'Meara <[email protected]> Date: Wed Jun 26 18:51:44 2024 +0000 Reapply "Feature/serialization minimap (#23)" This reverts commit 8255413. commit 1a772f6480d1edf6fa383e2e6f4dc6138209b88e Merge: 8255413 ebca7ce Author: Whitney O'Meara <[email protected]> Date: Wed Jun 26 18:16:19 2024 +0000 Merge remote-tracking branch 'origin/main' into feature/mapService commit ebca7ce Author: Moon Moon <[email protected]> Date: Wed Jun 26 13:31:05 2024 -0400 Preventing npe from empty data or ingest type string (#38) commit 8255413 Author: Whitney O'Meara <[email protected]> Date: Tue Jun 25 13:32:06 2024 +0000 Revert "Feature/serialization minimap (#23)" This reverts commit 5b62bf6. commit 7760b83 Author: Moriarty <[email protected]> Date: Tue Jun 25 09:45:29 2024 +0000 [maven-release-plugin] prepare for next development iteration commit 6a34dce Author: Moriarty <[email protected]> Date: Tue Jun 25 09:45:27 2024 +0000 [maven-release-plugin] prepare release 4.0.2 commit f589568 Merge: add487b 5b62bf6 Author: Whitney O'Meara <[email protected]> Date: Mon Jun 24 22:08:51 2024 +0000 Merge remote-tracking branch 'origin/main' into feature/mapService commit 5b62bf6 Author: Moon Moon <[email protected]> Date: Mon Jun 24 13:42:14 2024 -0400 Feature/serialization minimap (#23) * Adding ability to parse string with minimap * Creating mini-map during serialization * Changing to TreeSet for ordering purposes * WIP forming new mini-map string * Ensuring ordered types during serialization * Removing duplicate unit test * Adding ability to parse string with minimap * Creating mini-map during serialization * Changing to TreeSet for ordering purposes * WIP forming new mini-map string * Ensuring ordered types during serialization * Removing duplicate unit test * Moving hard coded strings * Formatting * Removing old method calls * Removing unnecessary exception throwing * Formatting * Updating to remove HashSet to preserve ordering * Updating unit tests * Updating unit tests again * Updating unit tests again again * Formatting * Removing old methods * Adding in fieldName creation * Updates based on testing * Returning immutable map * Fixing concatenated dataTypes --------- Co-authored-by: Ivan Bella <[email protected]> commit 6f2d4d4 Author: Moriarty <[email protected]> Date: Mon Jun 24 12:15:21 2024 -0400 Support field cardinality across a date range (#37) * Add seeking filter for the F column to support getting field cardinality across a date range * guard against empty ranges * move log messages from debug to trace commit 44482bd Author: Moriarty <[email protected]> Date: Tue Jun 18 10:57:37 2024 -0400 Cleanup code, logging formats for AllFieldMetadataHelper. Wrap scanner in try-with-resources blocks (#36) commit f288080 Author: Moriarty <[email protected]> Date: Fri Jun 14 09:30:16 2024 -0400 MetadataHelper address try-with-resources warnings (#35) * Wrap scanners in try-with-resources * Additional instances of try-with-resources commit c33f5ea Author: Moriarty <[email protected]> Date: Thu Jun 6 11:54:16 2024 +0000 [maven-release-plugin] prepare for next development iteration commit e86baa2 Author: Moriarty <[email protected]> Date: Thu Jun 6 11:54:14 2024 +0000 [maven-release-plugin] prepare release 4.0.1 commit cb733db Author: Moriarty <[email protected]> Date: Wed Jun 5 08:07:04 2024 -0400 Add table test for the MetadataHelper, update docs, general code cleanup (#34) commit add487b Merge: bada436 2948b55 Author: Whitney O'Meara <[email protected]> Date: Thu May 23 04:18:11 2024 +0000 Merge remote-tracking branch 'origin/main' into feature/mapService commit 2948b55 Author: Whitney O'Meara <[email protected]> Date: Mon May 20 17:49:29 2024 +0000 [maven-release-plugin] prepare for next development iteration commit a30194b Author: Whitney O'Meara <[email protected]> Date: Mon May 20 17:49:27 2024 +0000 [maven-release-plugin] prepare release 4.0.0 commit 870ccfd Author: Whitney O'Meara <[email protected]> Date: Mon May 20 17:48:56 2024 +0000 updated to tagged release commit 570d8a9 Author: Whitney O'Meara <[email protected]> Date: Mon May 20 12:32:27 2024 -0400 Feature/query microservices (#33) * bumped release version * bumped versions for some modules * Updated with latest changes from main/integration * Updated package names for commons.lang3 classes due to type-utils fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix several instances of try-with-resources warnings.