Fix wav saving #64
Closed
Fix wav saving #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmPals
approved these changes
Apr 14, 2021
LucasEGomes
approved these changes
Apr 17, 2021
|
Tested on a couple Xiaomis and it's working |
|
Nice fix! Do you think it would be an idea/possible to write 44 "filler" bytes (size of wavheader) to the filestream in the beginning and overwrite those in the end? This would avoid using a memorystream, which could potentially create a memory problem with longer recordings. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes wav saving as the original code overwrites the initial bytes of audio. Also fixes #53 as some platform enforces correctness of wav files when playing them