-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Cross Platform (Issue #30) #31
base: main
Are you sure you want to change the base?
Enable Cross Platform (Issue #30) #31
Conversation
(To Replace PBIXInspectorWinLibrary).
Changes Constants to use / path instead of \ to be platform agnostic.
…o allow for System Agnostic applications.
…rence error presents in Linux.
Many thanks Rhys, I will review asap :) This had been on my to-do list and I'm really grateful for your contribution. |
Thanks again Rhys, identified some issues i.e. 1) unit test fails due to win library rename, 2) font size in Skia wireframe pages is smaller than original, 3) as yet unidentified cause of error when rendering wireframes for a local report.json file. Shall I commit fixes to your branch first? |
Hey, ah great - thanks for spotting. Feel free to check in any already made fixes to the branch, I'll take a look into the local report.json failure as soon as I get a chance. |
Changes
/
instead of Back Slash\
The intention of this change is in relation to Issue #30 to enable Cross-Platform output of all formats, including HTML and Images.