Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Cross Platform (Issue #30) #31

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

RhysTabor-dev
Copy link

Changes

The intention of this change is in relation to Issue #30 to enable Cross-Platform output of all formats, including HTML and Images.

@NatVanG
Copy link
Owner

NatVanG commented Apr 18, 2024

Many thanks Rhys, I will review asap :) This had been on my to-do list and I'm really grateful for your contribution.

@NatVanG
Copy link
Owner

NatVanG commented Apr 24, 2024

Thanks again Rhys, identified some issues i.e. 1) unit test fails due to win library rename, 2) font size in Skia wireframe pages is smaller than original, 3) as yet unidentified cause of error when rendering wireframes for a local report.json file. Shall I commit fixes to your branch first?

@RhysTabor-dev
Copy link
Author

Thanks again Rhys, identified some issues i.e. 1) unit test fails due to win library rename, 2) font size in Skia wireframe pages is smaller than original, 3) as yet unidentified cause of error when rendering wireframes for a local report.json file. Shall I commit fixes to your branch first?

Hey, ah great - thanks for spotting. Feel free to check in any already made fixes to the branch, I'll take a look into the local report.json failure as soon as I get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants