Tooltips are now conditional on the hierarchy #1371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
Link to relevant issue(s), if any
Description of the changes in this PR
Hierarchy is not always available. When it is not, we want to display a tooltip with a warning/note about it. However, the tooltips were always enabled, causing an empty tooltip sometimes.
Known problems or uncertainties in this PR
Hard to test. I looked at the previous modified files in the linked PR, then repeated the same fix. Tested on Firefox with the :hover modified on the hierarchy tab. In one case the tooltip is displayed as hierarchy is disabled, and in the other nothing is shown.
Hopefully that fixes the issue. Sorry!
Checklist
.sr-only
class, color contrast)