Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips are now conditional on the hierarchy #1371

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

kinow
Copy link
Collaborator

@kinow kinow commented Oct 4, 2022

Reasons for creating this PR

Link to relevant issue(s), if any

Description of the changes in this PR

Hierarchy is not always available. When it is not, we want to display a tooltip with a warning/note about it. However, the tooltips were always enabled, causing an empty tooltip sometimes.

Known problems or uncertainties in this PR

Hard to test. I looked at the previous modified files in the linked PR, then repeated the same fix. Tested on Firefox with the :hover modified on the hierarchy tab. In one case the tooltip is displayed as hierarchy is disabled, and in the other nothing is shown.

image
image

Hopefully that fixes the issue. Sorry!

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.0% 2.0% Duplication

@kinow kinow changed the title Tooltips are now conditional on the hierarchy of the vocab Tooltips are now conditional on the hierarchy Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 71.17% // Head: 71.17% // No change to project coverage 👍

Coverage data is based on head (6dc902d) compared to base (77eb4a2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1371   +/-   ##
=========================================
  Coverage     71.17%   71.17%           
  Complexity     1650     1650           
=========================================
  Files            32       32           
  Lines          3788     3788           
=========================================
  Hits           2696     2696           
  Misses         1092     1092           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@osma
Copy link
Member

osma commented Oct 4, 2022

Wow, thanks a lot for the quick fix @kinow ! I will test this and if it works OK, I will merge it.

@kinow
Copy link
Collaborator Author

kinow commented Oct 4, 2022

Wow, thanks a lot for the quick fix @kinow ! I will test this and if it works OK, I will merge it.

Not a problem @osma. Good to fix this while it's still fresh on my (normally short-term) memory. Let me know if that works 👍 Thanks!

@osma
Copy link
Member

osma commented Oct 4, 2022

Works perfectly! Thanks a lot @kinow !

@osma osma merged commit ac64a05 into NatLibFi:master Oct 4, 2022
@osma osma self-assigned this Oct 4, 2022
@osma osma added the bug label Oct 4, 2022
@osma osma added this to the 2.16 milestone Oct 4, 2022
@kinow kinow deleted the make-tooltips-conditional branch October 4, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants