Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

50/update zola dtm link #1158

Closed
wants to merge 50 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
34ee338
Commit after running ember-cli-update and resolving conflicts
TylerMatteo Jun 13, 2023
0980fca
Various dependency upgrades, replace deprecated link-to syntax
TylerMatteo Jun 14, 2023
770454a
Downgrade ember-data, update last link-to, and fix some implicit this's
TylerMatteo Jun 15, 2023
a105999
Run template linter with fix flag
TylerMatteo Jun 15, 2023
ec86835
Fix implicit this's, upgrade nycplanning/ember and ember-mapbox-gl, s…
TylerMatteo Jun 16, 2023
5f11e3b
Update various dependency, remove placeholder component for now repla…
TylerMatteo Jun 22, 2023
96bc921
Fix tests, fix zoom-dependent-label, point to branch of nycplanning/e…
TylerMatteo Jun 30, 2023
af007bb
update deps to remove need for resolutions. Uses ember-cli-foundation…
TylerMatteo Jul 3, 2023
e68b225
Ran ember-cli-update to 4.12, regenerated lock file, manually downgra…
TylerMatteo Jul 4, 2023
eec1d5e
Add resolution and downgrade ember-cli-mirage. Remove usage of ember-…
TylerMatteo Jul 5, 2023
4a09b19
Delete map feature fragment models and ember-data-model-fragments dep…
TylerMatteo Jul 5, 2023
0659308
Updated to ember-cli-mirage alpha release. Tests mostly passing with …
TylerMatteo Jul 12, 2023
94da0c7
Fix carto download helper test
TylerMatteo Jul 12, 2023
8680d9d
Remove ember-cli-babel 6 dependencies
TylerMatteo Jul 12, 2023
eb9e087
Remove unnecessary resolutions from package.json
TylerMatteo Jul 12, 2023
f953490
Upgrade ember-cli-update version to fix some deprecation warnings
TylerMatteo Jul 12, 2023
7ed06a4
Reinstall with new commits to nycplanning/ember branch
TylerMatteo Jul 13, 2023
9e38f74
Run sass division migrator
TylerMatteo Jul 13, 2023
fe7fb68
update ember-local-storage and refactor out deprecated -outputs argument
TylerMatteo Jul 13, 2023
65cbcc2
Move icon config to icons.js file
TylerMatteo Jul 13, 2023
122389d
Add babel/core for peer dep condition
TylerMatteo Jul 13, 2023
b939cd0
Upgrade font awesome deps and install deps to resolve peer dep warnings
TylerMatteo Jul 14, 2023
24516ad
Remove ember-fetch in favor of native fetch
TylerMatteo Jul 21, 2023
8e638c6
style loading spinners used outside of the map
TylerMatteo Jul 21, 2023
e369f31
Switch ember-cli-nouislider to package published from fork
TylerMatteo Jul 21, 2023
831cd2a
Point to ember-parachute and ember-cli-nouislider fork packages
TylerMatteo Jul 22, 2023
64fafc5
Use package from fork of ember-mapbox-gl-draw
TylerMatteo Jul 22, 2023
dde705e
Point to package from fork of ember-cli-foundation-6-sass
TylerMatteo Jul 22, 2023
371a6f2
Switch to prerelease v3 @nycplanning/ember
TylerMatteo Jul 25, 2023
ce4b349
point to new @nycplanning/ember prerelease
TylerMatteo Aug 2, 2023
3b672f3
Fix remaining js lint errors, either by fixing or by adding rule exce…
TylerMatteo Aug 13, 2023
8f98dd7
Update tests and add resolution to fix dependency lint error
TylerMatteo Aug 17, 2023
00ed99d
task/14799-remove-date-references-in-zola-data-info-tab
horatiorosa Sep 25, 2023
35f1ac0
Fix bbl test
allthesignals Oct 2, 2023
b7cd17d
Fix intersecting layers; bump ec; refactor syntax
allthesignals Oct 3, 2023
e06f8bc
await settled
allthesignals Oct 3, 2023
1758c53
Address promise proxy thing
allthesignals Oct 3, 2023
032028e
Merge branch 'develop' into upgrade-ember4-node18-2
allthesignals Oct 3, 2023
786b15a
Fix old test
allthesignals Oct 3, 2023
cf602b9
Bump node in GH CI
allthesignals Oct 3, 2023
c5299e2
Force resolution
allthesignals Oct 3, 2023
9449a64
Use CI friendly test command
allthesignals Oct 3, 2023
4948d8e
Remove console log
allthesignals Oct 5, 2023
bffbfc2
Fix lint errors and bug with layer groups fixture
TylerMatteo Oct 11, 2023
8a53656
Upgrade to 3.0.0 release of @nycplanning/ember
TylerMatteo Oct 11, 2023
c70d4f0
Add special handling for c3a districts to tax-lot.js component
TylerMatteo Oct 18, 2023
17b73d7
Merge branch 'develop' into upgrade-ember4-node18-2
TylerMatteo Oct 23, 2023
26a43ef
Merge pull request #1146 from NYCPlanning/upgrade-ember4-node18-2
TylerMatteo Oct 23, 2023
777cd81
Merge pull request #1150 from NYCPlanning/task/14799-remove-date-refe…
horatiorosa Oct 31, 2023
7f704bb
1155 updated zola DTM link maps.nyc to gis.nyc, updated dtm link test
horatiorosa Nov 22, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .ember-cli
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,11 @@

Setting `disableAnalytics` to true will prevent any data from being sent.
*/
"disableAnalytics": false
"disableAnalytics": false,

/**
Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript
rather than JavaScript by default, when a TypeScript version of a given blueprint is available.
*/
"isTypeScriptProject": false
}
5 changes: 4 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,7 @@
# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/package.json.ember-try
/npm-shrinkwrap.json.ember-try
/package.json.ember-try
/package-lock.json.ember-try
/yarn.lock.ember-try
83 changes: 49 additions & 34 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,28 +1,29 @@
'use strict';

module.exports = {
root: true,
parser: 'babel-eslint',
parserOptions: {
ecmaVersion: 2018,
parser: '@babel/eslint-parser',
ecmaVersion: 'latest',
sourceType: 'module',
ecmaFeatures: {
legacyDecorators: true
}
requireConfigFile: false,
babelOptions: {
plugins: [
['@babel/plugin-proposal-decorators', { decoratorsBeforeExport: true }],
],
},
},
plugins: [
'ember'
],
plugins: ['ember', 'decorator-position'],
extends: [
'eslint:recommended',
'airbnb-base',
'plugin:ember-best-practices/recommended',
'plugin:ember/recommended',
'plugin:decorator-position/ember',
'plugin:prettier/recommended',
],
env: {
browser: true,
},
globals:{
'$': true,
globals: {
$: true,
d3: true,
},
rules: {
Expand All @@ -34,40 +35,54 @@ module.exports = {
'space-before-function-paren': 0,
'prefer-arrow-callback': 0,
'no-underscore-dangle': 0,
'camelcase': 0,
camelcase: 0,
'class-methods-use-this': 0,
'max-len': 0,
'no-param-reassign': 0,
'ember/avoid-leaking-state-in-ember-objects': 0,
'ember-best-practices/require-dependent-keys': 0,
'no-undef': 0,
'ember/no-classic-components': 'warn',
'ember/no-classic-classes': 'warn',
'ember/no-get': 'warn',
'ember/no-actions-hash': 'warn',
'ember/require-tagless-components': 'warn',
'ember/no-observers': 'warn',
'ember/classic-decorator-no-classic-methods': 'warn',
'ember/classic-decorator-hooks': 'warn',
'ember/no-component-lifecycle-hooks': 'warn',
'ember/no-empty-glimmer-component-classes': 'warn',
'ember/require-computed-macros': 'warn',
'ember/no-computed-properties-in-native-classes': 'warn',
'ember/no-legacy-test-waiters': 'warn',
'ember/no-mixins': 'warn',
'ember/no-new-mixins': 'warn',
'ember/avoid-leaking-state-in-ember-objects': 'warn',
'ember/no-incorrect-calls-with-inline-anonymous-functions': 'warn',
'max-classes-per-file': 0,
'decorator-position/decorator-position': 0,
},
overrides: [
// node files
{
files: [
'.eslintrc.js',
'.template-lintrc.js',
'ember-cli-build.js',
'testem.js',
'blueprints/*/index.js',
'config/**/*.js',
'lib/*/index.js'
'./.eslintrc.js',
'./.prettierrc.js',
'./.stylelintrc.js',
'./.template-lintrc.js',
'./ember-cli-build.js',
'./testem.js',
'./blueprints/*/index.js',
'./config/**/*.js',
'./lib/*/index.js',
'./server/**/*.js',
],
parserOptions: {
sourceType: 'script'
sourceType: 'script',
},
env: {
browser: false,
node: true
node: true,
},
plugins: ['node'],
extends: ['plugin:node/recommended'],
rules: {
// this can be removed once the following is fixed
// https://github.com/mysticatea/eslint-plugin-node/issues/77
'node/no-unpublished-require': 'off'
}
}
]
extends: ['plugin:n/recommended'],
},
],
};
47 changes: 47 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: CI

on:
push:
branches:
- main
- master
pull_request: {}

concurrency:
group: ci-${{ github.head_ref || github.ref }}
cancel-in-progress: true

jobs:
lint:
name: "Lint"
runs-on: ubuntu-latest
timeout-minutes: 10

steps:
- uses: actions/checkout@v3
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 18.x
cache: yarn
- name: Install Dependencies
run: yarn install --frozen-lockfile
- name: Lint
run: yarn lint

test:
name: "Test"
runs-on: ubuntu-latest
timeout-minutes: 10

steps:
- uses: actions/checkout@v3
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 18.x
cache: yarn
- name: Install Dependencies
run: yarn install --frozen-lockfile
- name: Run Tests
run: yarn test
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: install dependencies
run: yarn install --frozen-lockfile --non-interactive
- name: test
Expand Down
6 changes: 6 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,13 @@ development.env
# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/npm-shrinkwrap.json.ember-try
/package.json.ember-try

.eslintcache
.yalc
/package-lock.json.ember-try
/yarn.lock.ember-try

# broccoli-debug
/DEBUG/
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.15.1
18.16.0
4 changes: 4 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,12 @@
/coverage/
!.*
.eslintcache
.lint-todo/

# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/npm-shrinkwrap.json.ember-try
/package.json.ember-try
/package-lock.json.ember-try
/yarn.lock.ember-try
11 changes: 8 additions & 3 deletions .prettierrc.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
'use strict';

module.exports = {
singleQuote: true,
overrides: [
{
files: '*.{js,ts}',
options: {
singleQuote: true,
},
},
],
};
8 changes: 8 additions & 0 deletions .stylelintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# unconventional files
/blueprints/*/files/

# compiled output
/dist/

# addons
/.node_modules.ember-try/
3 changes: 3 additions & 0 deletions .stylelintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module.exports = {
extends: ['stylelint-config-standard', 'stylelint-prettier/recommended'],
};
15 changes: 13 additions & 2 deletions .template-lintrc.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
'use strict';

module.exports = {
extends: 'recommended',
rules: {
'no-inline-styles': false,
'no-curly-component-invocation': false,
'no-action': false,
'no-yield-only': false,
'require-presentational-children': false,
'no-invalid-interactive': false,
'no-unused-block-params': false,
'no-negated-condition': false,
'link-href-attributes': false,
'no-nested-interactive': false,
'require-input-label': false,
},
};
5 changes: 2 additions & 3 deletions app/adapters/application.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import DS from 'ember-data';
import JSONAPIAdapter from '@ember-data/adapter/json-api';

export default DS.JSONAPIAdapter.extend({
});
export default JSONAPIAdapter.extend({});
4 changes: 3 additions & 1 deletion app/adapters/bookmark.js
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
export { default } from 'ember-local-storage/adapters/adapter';
import LocalAdapter from 'ember-local-storage/adapters/adapter';

export default LocalAdapter;
7 changes: 2 additions & 5 deletions app/adapters/commercial-overlay.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { buildSqlUrl } from '../utils/carto';
import CartoGeojsonFeatureAdapter from './carto-geojson-feature';

const SQL = function(id) {
const SQL = function (id) {
return `SELECT * FROM (
SELECT ST_CollectionExtract(ST_Collect(the_geom),3) as the_geom,
overlay as id,
Expand All @@ -13,9 +13,6 @@ const SQL = function(id) {

export default CartoGeojsonFeatureAdapter.extend({
urlForFindRecord(id) {
return buildSqlUrl(
SQL(id),
'geojson',
);
return buildSqlUrl(SQL(id), 'geojson');
},
});
3 changes: 1 addition & 2 deletions app/adapters/layer.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import ApplicationAdapter from './application';

export default ApplicationAdapter.extend({
});
export default ApplicationAdapter.extend({});
7 changes: 2 additions & 5 deletions app/adapters/lot.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const LotColumnsSQL = [
'LOWER(zonemap) AS zonemap',
];

export const cartoQueryTemplate = function(id) {
export const cartoQueryTemplate = function (id) {
return `SELECT ${LotColumnsSQL.join(',')},
/* id:${id} */
st_x(st_centroid(the_geom)) as lon, st_y(st_centroid(the_geom)) as lat,
Expand All @@ -64,9 +64,6 @@ export default CartoGeojsonFeatureAdapter.extend({
return this._super(status, headers, payload, requestData);
},
urlForFindRecord(id) {
return buildSqlUrl(
cartoQueryTemplate(id),
'geojson',
);
return buildSqlUrl(cartoQueryTemplate(id), 'geojson');
},
});
7 changes: 2 additions & 5 deletions app/adapters/special-purpose-district.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { buildSqlUrl } from '../utils/carto';
import CartoGeojsonFeatureAdapter from './carto-geojson-feature';

const SQL = function(id) {
const SQL = function (id) {
return `SELECT cartodb_id as id,
cartodb_id,
the_geom,
Expand All @@ -13,9 +13,6 @@ const SQL = function(id) {

export default CartoGeojsonFeatureAdapter.extend({
urlForFindRecord(id) {
return buildSqlUrl(
SQL(id),
'geojson',
);
return buildSqlUrl(SQL(id), 'geojson');
},
});
7 changes: 2 additions & 5 deletions app/adapters/special-purpose-subdistrict.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { buildSqlUrl } from '../utils/carto';
import CartoGeojsonFeatureAdapter from './carto-geojson-feature';

const SQL = function(id) {
const SQL = function (id) {
return `SELECT
cartodb_id as id,
cartodb_id,
Expand All @@ -15,9 +15,6 @@ const SQL = function(id) {

export default CartoGeojsonFeatureAdapter.extend({
urlForFindRecord(id) {
return buildSqlUrl(
SQL(id),
'geojson',
);
return buildSqlUrl(SQL(id), 'geojson');
},
});
7 changes: 2 additions & 5 deletions app/adapters/zoning-district.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { buildSqlUrl } from '../utils/carto';
import CartoGeojsonFeatureAdapter from './carto-geojson-feature';

const SQL = function(id) {
const SQL = function (id) {
return `SELECT *
FROM (
SELECT ST_CollectionExtract(ST_Collect(the_geom),3) as the_geom,
Expand All @@ -15,9 +15,6 @@ const SQL = function(id) {

export default CartoGeojsonFeatureAdapter.extend({
urlForFindRecord(id) {
return buildSqlUrl(
SQL(id),
'geojson',
);
return buildSqlUrl(SQL(id), 'geojson');
},
});
Loading
Loading