Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1155 Update ZOLA DTM link #1157

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

horatiorosa
Copy link
Contributor

Description

This PR updates the digital tax map link from http://maps.nyc.gov/taxmap/map.htm to http://gis.nyc.gov/taxmap/map.htm
in an effort to avoid a 400 on redirect on Chrome browser when redirected to the DOF hosted tax maps

Tickets

Closes #1155

@horatiorosa horatiorosa self-assigned this Nov 22, 2023
@horatiorosa horatiorosa requested a review from a team as a code owner November 22, 2023 17:22
Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for labs-zola ready!

Name Link
🔨 Latest commit 7f704bb
🔍 Latest deploy log https://app.netlify.com/sites/labs-zola/deploys/655e392396c537000877fcc0
😎 Deploy Preview https://deploy-preview-1157--labs-zola.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@horatiorosa horatiorosa force-pushed the 50/investigate-zola-dtm-issues branch from d463d9f to 7f704bb Compare November 22, 2023 17:23
Copy link
Contributor

@TylerMatteo TylerMatteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@horatiorosa looks good. Because develop has the upgrade changes that are still in QA, please open another PR for this feature branch against master.

@horatiorosa
Copy link
Contributor Author

horatiorosa commented Nov 24, 2023

@horatiorosa looks good. Because develop has the upgrade changes that are still in QA, please open another PR for this feature branch against master.

I think I would need to open new PR bc unless I have lost my mind, the digitalTaxmapLink function is in /app/models/map-features/lot.js on master, while on develop it's in app/components/layer-record-views/tax-lot.js.

I am assuming some refactoring was done.

I will proceed and make a new PR on a fresh branch from master.
#1159

@horatiorosa horatiorosa merged commit 4eab32e into develop Nov 27, 2023
4 of 9 checks passed
@horatiorosa horatiorosa deleted the 50/investigate-zola-dtm-issues branch November 27, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate and resolve Zola DTM link issues
2 participants