Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run code quality checks on pull requests #1285

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Run code quality checks on pull requests #1285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/code-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: 🚧 Check code quality
on:
pull_request:

jobs:
test-client:
name: 🧪 Test client code
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
sparse-checkout: client
- uses: actions/setup-node@v1
with:
node-version: 12.x
- name: install dependencies
run: yarn install --frozen-lockfile --non-interactive
working-directory: client
- name: build
env:
DISABLE_SOURCE_MAPS: true
BROCCOLI_ENV: production
run: yarn build
working-directory: client
- name: test
run: yarn test
working-directory: client
24 changes: 12 additions & 12 deletions client/config/environment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
module.exports = function(environment) {
const ENV = {
modulePrefix: "client",
modulePrefix: 'client',
environment,
rootURL: "/",
locationType: "auto",
rootURL: '/',
locationType: 'auto',
host: getHost(environment),
NYCIDDomain: getOAuthDomain(environment),
NYCIDLocation: getOAuthLoginEndpoint(environment),
Expand All @@ -22,9 +22,9 @@ module.exports = function(environment) {
},
fontawesome: {
icons: {
"free-brands-svg-icons": "all",
"free-regular-svg-icons": "all",
"free-solid-svg-icons": "all",
'free-brands-svg-icons': 'all',
'free-regular-svg-icons': 'all',
'free-solid-svg-icons': 'all',
},
},

Expand All @@ -33,10 +33,10 @@ module.exports = function(environment) {
// when it is created
},

"labs-search": {
host: "https://search-api-production.herokuapp.com",
route: "search",
helpers: ["geosearch-v2", "bbl"],
'labs-search': {
host: 'https://search-api-production.herokuapp.com',
route: 'search',
helpers: ['geosearch-v2', 'bbl'],
},
};

Expand Down Expand Up @@ -142,6 +142,6 @@ function getMaintenanceTimes() {
return [MAINTENANCE_START, MAINTENANCE_END];
}

function getFeatureFlagSelfService() {
return process.env.FEATURE_FLAG_SELF_SERVICE === "ON";
function getFeatureFlagSelfService() {
return process.env.FEATURE_FLAG_SELF_SERVICE === 'ON';
}
Loading