Skip to content

Commit

Permalink
project description form field
Browse files Browse the repository at this point in the history
  • Loading branch information
horatiorosa committed Nov 8, 2024
1 parent 34ac7fe commit 85a9c38
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 0 deletions.
2 changes: 2 additions & 0 deletions client/app/components/projects/new.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
/>
<Projects::ProjectsNewAddContacts
@form={{saveableProjectsNewForm}} />
<Projects::ProjectsNewProjectDescription
@form={{saveableProjectsNewForm}} />
</div>
<div class="cell large-4 sticky-sidebar">
<saveableProjectsNewForm.PageNav>
Expand Down
2 changes: 2 additions & 0 deletions client/app/components/projects/projects-new-add-contacts.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
id={{Q.questionId}}
@showCounter={{true}}
@maxlength="10"
placeholder='2125551212'
/>
</Ui::Question>

Expand Down Expand Up @@ -118,6 +119,7 @@
id={{Q.questionId}}
@showCounter={{true}}
@maxlength="10"
placeholder='2125551212'
/>
</Ui::Question>
</form.Section>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{{#let @form as |form|}}
<form.Section @title="Project Description">
<Ui::Question @required={{true}} as |Q|>
<Q.Label>
Please replace information in the brackets to the best of your ability.
</Q.Label>

<form.Field

This comment has been minimized.

Copy link
@TangoYankee

TangoYankee Nov 8, 2024

Member

The text area appears to have a default character limit of 2000. I think the feature request states that the limit should be 500 characters.

This comment has been minimized.

Copy link
@horatiorosa

horatiorosa Nov 8, 2024

Author Contributor

yes, great catch. I'll update this!

@attribute="dcpProjectbrief"

This comment has been minimized.

Copy link
@TangoYankee

TangoYankee Nov 8, 2024

Member

I believe we need to add this attribute to the model defined in the routes/projects. We also need to add its validations to validations/submittable-projects-new-form

This comment has been minimized.

Copy link
@horatiorosa

horatiorosa Nov 8, 2024

Author Contributor

Wups. My bad! Correction forthcoming.

@type="text-area"
id={{Q.questionId}}
placeholder='A [action(s)] [ZR#&apos;s for ZR, ZS, ZA] to facilitate a [new] [# of max stories], [total zsf, (# DU&apos;s)], [use] development, including [sf for each use, sf open space], is being sought by [public/private] [applicant] at [address] in [neighborhood], [Community District], [Borough].' />

This comment has been minimized.

Copy link
@TangoYankee

TangoYankee Nov 8, 2024

Member

The project brief is described in the feature request as "pre-populated". I think this means it should be a default value, rather than a placeholder. Placeholders don't actually populate the field

This comment has been minimized.

Copy link
@horatiorosa

horatiorosa Nov 8, 2024

Author Contributor

If the copy is actually the default value of the form, it might cause friction for the user that would then need to erase and enter in their own description.
It would duplicate the CRM default behavior as that field seems pre-populated with this particular copy.

Should we bring this to the Liz's attention?

</Ui::Question>
</form.Section>
{{/let}}

0 comments on commit 85a9c38

Please sign in to comment.