Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library to Ingest: weekly OpenData templates #1289

Merged
merged 22 commits into from
Dec 18, 2024
Merged

Conversation

sf-dcp
Copy link
Contributor

@sf-dcp sf-dcp commented Nov 27, 2024

Closes #1247. Reports for specific datasets can be found there.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.00%. Comparing base (72a4932) to head (3b0b26d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1289      +/-   ##
==========================================
- Coverage   70.10%   70.00%   -0.10%     
==========================================
  Files         115      114       -1     
  Lines        6141     6121      -20     
  Branches      702      702              
==========================================
- Hits         4305     4285      -20     
  Misses       1690     1690              
  Partials      146      146              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- name: most_curre
- name: status
- name: wkb_geometry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latitude & longitude columns no longer exist at the source - remove. These columns are actually not used in the build, so no impact. Added wkb_geometry bc it's actually expected.

@sf-dcp sf-dcp force-pushed the sf-ingest-open-data-1 branch 3 times, most recently from d0a335a to 529f0e1 Compare December 9, 2024 15:51
@sf-dcp sf-dcp force-pushed the sf-ingest-open-data-1 branch 14 times, most recently from 3e7a800 to 4dd521e Compare December 17, 2024 23:11
@sf-dcp sf-dcp force-pushed the sf-ingest-open-data-1 branch from 71583a5 to 20785aa Compare December 18, 2024 01:02
@sf-dcp sf-dcp marked this pull request as ready for review December 18, 2024 01:04
@fvankrieken
Copy link
Contributor

I'm actually very curious with dpr_parksproperties that we're still getting a timestamp for that field but losing timezone. Can you look at the raw geojson if you have it and see the format of the timestamps? Wondering if library is assuming a time zone or if ingest is missing it

@fvankrieken
Copy link
Contributor

Looks largely good though, both code changes and reports. I'd like someone other than me to approve if that's alright, just think it would be good for others to see and think about the decisions/thoughts around the reports since these same types of issues will definitely keep coming up

@sf-dcp
Copy link
Contributor Author

sf-dcp commented Dec 18, 2024

@damonmcc @alexrichey

@sf-dcp
Copy link
Contributor Author

sf-dcp commented Dec 18, 2024

I'm actually very curious with dpr_parksproperties that we're still getting a timestamp for that field but losing timezone. Can you look at the raw geojson if you have it and see the format of the timestamps? Wondering if library is assuming a time zone or if ingest is missing it

Here is an example of how it looks in the raw gejson for both library and ingest: "acquisitiondate": "1900-09-22T00:00:00.000"

Copy link
Member

@damonmcc damonmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appreciate the notes in the issue on report diffs!

@sf-dcp
Copy link
Contributor Author

sf-dcp commented Dec 18, 2024

@fvankrieken the weekly OpenData job ran successfully 🎉 And now I have my very own bucket

@sf-dcp sf-dcp merged commit a041b06 into main Dec 18, 2024
39 of 40 checks passed
@sf-dcp sf-dcp deleted the sf-ingest-open-data-1 branch December 18, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Ingest Migration - OpenData Datasets
4 participants