-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library to Ingest: weekly OpenData templates #1289
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1289 +/- ##
==========================================
- Coverage 70.10% 70.00% -0.10%
==========================================
Files 115 114 -1
Lines 6141 6121 -20
Branches 702 702
==========================================
- Hits 4305 4285 -20
Misses 1690 1690
Partials 146 146 ☔ View full report in Codecov by Sentry. |
- name: most_curre | ||
- name: status | ||
- name: wkb_geometry | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latitude
& longitude
columns no longer exist at the source - remove. These columns are actually not used in the build, so no impact. Added wkb_geometry
bc it's actually expected.
d0a335a
to
529f0e1
Compare
3e7a800
to
4dd521e
Compare
Remove lon and lat columns from `lpc_landmarks` source in GFT - no longer exist at the source. Note, these columns are not used in GFT build.
71583a5
to
20785aa
Compare
I'm actually very curious with dpr_parksproperties that we're still getting a timestamp for that field but losing timezone. Can you look at the raw geojson if you have it and see the format of the timestamps? Wondering if library is assuming a time zone or if ingest is missing it |
Looks largely good though, both code changes and reports. I'd like someone other than me to approve if that's alright, just think it would be good for others to see and think about the decisions/thoughts around the reports since these same types of issues will definitely keep coming up |
Here is an example of how it looks in the raw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appreciate the notes in the issue on report diffs!
@fvankrieken the weekly OpenData job ran successfully 🎉 And now I have my very own bucket |
Closes #1247. Reports for specific datasets can be found there.