Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubb to allow nullable enum #322

Closed
wants to merge 6 commits into from

Conversation

pratishta
Copy link
Contributor

@pratishta pratishta commented Jun 17, 2024

Closes #321

Will squash before merging after initial review. Upgrading Kubb resulted in:

  • Having to update Zod version from 3.22 to 3.23 due to allowing Zod string to validate date format
  • Updating the schema type in the pipes to expect union type for the schema params (e.g. ZodObject<T> to ZodObject<T> | ZodOptional<ZodObject<T>>.
  • Forcing MVT schema to return a string

@pratishta pratishta requested review from TangoYankee and a team June 17, 2024 18:43
@pratishta pratishta marked this pull request as ready for review June 17, 2024 18:43
Copy link
Member

@TangoYankee TangoYankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Investigating downstream effects

@TangoYankee
Copy link
Member

TangoYankee commented Jun 18, 2024

@pratishta , I'm working on the validation and decode pipes. I'll create a branch off of this one and share my findings when they're ready.

EDIT: The branch- ty/decode-param

@TangoYankee
Copy link
Member

Closing in favor of #326, which has the updated pipes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade kubb version to allow nullable type for capital project category
2 participants