Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests and schemas for communitydistricts by boroughID #311

Closed
3 tasks done
TangoYankee opened this issue Jun 7, 2024 · 0 comments · Fixed by #312
Closed
3 tasks done

Update tests and schemas for communitydistricts by boroughID #311

TangoYankee opened this issue Jun 7, 2024 · 0 comments · Fixed by #312
Assignees
@horatiorosa

Comments

@TangoYankee
Copy link
Member

TangoYankee commented Jun 7, 2024 •
edited by horatiorosa
Loading

Description

Changes requested for findCommunityDistrictsByBoroughId

Acceptance criteria

Change schema/community-district to reflect updated OpenAPI pattern to include 0

Update borough.service.e2e-spec to include a test for 404's

Update borough.service.spec resource error with missing id test to reflect an ID not in the db instead of an empty string
horatiorosa added a commit that referenced this issue Jun 7, 2024
@horatiorosa
311 Update tests ans schemas for findCommunityDistrictsByBoroughId en…
c52c3a2 
…dpoint

 - borough.service.spec updated test for resource error with missing id test to reflect an ID not in the db instead of an empty string
 - borough.service.e2e-spec updated to include a test for 404
 - community-district schema updated to reflect updated OpenAPI pattern to include 0

Closes #311
@horatiorosa horatiorosa mentioned this issue Jun 7, 2024
Merged
horatiorosa added a commit that referenced this issue Jun 7, 2024
@horatiorosa
311 Update tests and schemas for findCommunityDistrictsByBoroughId en…
a545bd7 
…dpoint

 - borough.service.spec updated test for resource error with missing id test to reflect an ID not in the db instead of an empty string
 - borough.service.e2e-spec updated to include a test for 404
 - community-district schema updated to reflect updated OpenAPI pattern to include 0

Closes #311
horatiorosa added a commit that referenced this issue Jun 7, 2024
@horatiorosa
311 Update tests and schemas for findCommunityDistrictsByBoroughId en…
a4ff6a8 
…dpoint

 - borough.service.spec updated test for resource error with missing id test to reflect an ID not in the db instead of an empty string
 - borough.service.e2e-spec updated to include a test for 404
 - community-district schema updated to reflect updated OpenAPI pattern to include 0

Closes #311
horatiorosa added a commit that referenced this issue Jun 7, 2024
@horatiorosa
311 Update tests and schemas for findCommunityDistrictsByBoroughId en…
00a27de 
…dpoint

 - borough.service.spec updated test for resource error with missing id test to reflect an ID not in the db instead of an empty string
 - borough.service.e2e-spec updated to include a test for 404
 - community-district schema updated to reflect updated OpenAPI pattern to include 0

Closes #311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@horatiorosa horatiorosa

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@TangoYankee @horatiorosa