311 Update tests and schemas for findCommunityDistrictsByBoroughId en…

…dpoint

 - borough.service.spec updated test for resource error with missing id test to reflect an ID not in the db instead of an empty string
 - borough.service.e2e-spec updated to include a test for 404
 - community-district schema updated to reflect updated OpenAPI pattern to include 0

Closes #311

src/borough/borough.service.spec.ts

@@ -47,7 +47,7 @@ describe("Borough service unit", () => {
     });
 
     it("service should throw a resource error when requesting with a missing id", async () => {
-      const missingId = "";
+      const missingId = "9";
       const zoningDistrict =
         boroughService.findCommunityDistrictsByBoroughId(missingId);
       expect(zoningDistrict).rejects.toThrow(ResourceNotFoundException);

src/schema/community-district.ts

@@ -22,6 +22,6 @@ export const communityDistrict = pgTable(
 );
 
 export const communityDistrictEntitySchema = z.object({
-  boroughId: z.string().length(1).regex(new RegExp("[1-9]")),
+  boroughId: z.string().length(1).regex(new RegExp("[0-9]")),
   id: z.string().length(2).regex(new RegExp("^([0-9]{2})$")),
 });

test/borough/borough.e2e-spec.ts

@@ -76,6 +76,14 @@ describe("Borough e2e", () => {
       expect(response.body.error).toBe(HttpName.BAD_REQUEST);
     });
 
+    it("should 404 and when finding by a missing id", async () => {
+      const missingId = "9";
+      const response = await request(app.getHttpServer())
+        .get(`/boroughs/${missingId}/community-districts`)
+        .expect(404);
+      expect(response.body.message).toBe(HttpName.NOT_FOUND);
+    });
+
     it("should 500 when the database errors", async () => {
       const dataRetrievalException = new DataRetrievalException();
       jest