Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from link_pose to link_poses #267

Closed

Conversation

tylerlum
Copy link

I believe link_poses is always a Optional[Dict[str, Pose]]. Although Pose could technically be 1 or N poses, a dict of these should probably always be plural. This name change reduces confusion about link_pose and link_poses appearing to be different

This happens often, but isn't super clear to new users.

    link_poses = state.link_pose

However, this is a breaking change, so might not be worth the switch

@balakumar-s
Copy link
Collaborator

Instead of changing which would break existing code that depends on cuRobo, this will be added as an additional api in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants