Change from link_pose to link_poses #267
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe
link_poses
is always aOptional[Dict[str, Pose]]
. Although Pose could technically be 1 or N poses, a dict of these should probably always be plural. This name change reduces confusion aboutlink_pose
andlink_poses
appearing to be differentThis happens often, but isn't super clear to new users.
However, this is a breaking change, so might not be worth the switch