Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link_poses type hint to Optional[Dict[str, Pose]] #265

Closed

Conversation

tylerlum
Copy link

@tylerlum tylerlum commented May 10, 2024

  • Updates link_poses type hint to be more correct. Before there was inconsistency (eg. List[pose], Dict[str, Pose], Dict[str, List[Pose]]), which can be confusing to new users because it wasn't 100% clear that this was the same thing as CudaRobotModelState.link_pose. From looking at the code, it is quite clear that these should all be Optional[Dict[str, Pose]]

@balakumar-s
Copy link
Collaborator

Made it Union[None, Dict[str,Pose]] to be more clear. While Optional can also be used, I find it confusing when it's the output of a function. We will push this in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants