Add async-object #1339
Open
Add async-object #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like Tim Song reported this as a spurious warning: |
|
/ok to test |
|
/ok to test |
ericniebler
reviewed
May 24, 2024
Comment on lines
+86
to
+110
| auto async_destruct(storage& stg) noexcept { | ||
| auto make_destruct = [&] () noexcept -> exec::variant_sender<__destruction, __ref_storage> { | ||
| if (stg.__fyn_.has_value()) { | ||
| return stdexec::__apply( | ||
| [&](typename stdexec::__t<_FynId>&&... __fyn) noexcept { | ||
| return stdexec::__apply( | ||
| [&](typename stdexec::__t<_FynId>::storage&... __stgn) noexcept { | ||
| return stdexec::__apply( | ||
| [&](auto&&... __d) noexcept { | ||
| return stdexec::when_all( | ||
| stdexec::just(std::ref(stg)), | ||
| __d...); | ||
| }, exec::__tuple_reverse(std::make_tuple(exec::async_destruct(__fyn, __stgn)...))); | ||
| }, stg.__stgn_); | ||
| }, std::move(stg.__fyn_.value())); | ||
| } else { | ||
| return stdexec::just(std::ref(stg)); | ||
| } | ||
| }; | ||
| auto od = stdexec::then(make_destruct(), [](storage& stg) noexcept { | ||
| stg.o.reset(); | ||
| stg.__fyn_.reset(); | ||
| }); | ||
| return od; | ||
| } |
There was a problem hiding this comment.
hooo boy i can see why this takes a long time to compile.
There was a problem hiding this comment.
Yeah, that expression cannot be reduced using a function-ptr.
However, switching to member functions did make the compilation time much better.
There was a problem hiding this comment.
You're using stdexec::__apply, which means you're using std::tuple. You might be able to improve compile times a little bit by using stdexec::__tup::__tuple.
|
/ok to test |
|
/ok to test |
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds async-object as proposed in p2849r0.
There are a few issues with this PR
The worst issue is that
test_stop_object2.cpptakes 4m to compile. I had to make three cpp files with one test each to get that. When one cpp had all three test cases the compiler never completed. I did add-ftime-traceand loaded the 97mb json produced fortest_stop_object2.cpp. It might be thestd::visit/std::variant/std::tupleusage that is exploding compile times, but I do not have a solution yet.The other issue is that the build has warnings:
I am pretty sure that these are spurious since the
__decl_receivertype is only used to test for nothrow connect and that is why it does not implement the functions.