Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Update plugin versions for 24.10.0 [skip ci] #449

Merged
merged 3 commits into from
Oct 25, 2024
Merged

[Doc] Update plugin versions for 24.10.0 [skip ci] #449

merged 3 commits into from
Oct 25, 2024

Conversation

nvliyuan
Copy link
Collaborator

The PR is to update the plugin version to v24.10.0
Signed-off-by: liyuan [email protected]

@nvliyuan nvliyuan self-assigned this Oct 21, 2024
jlowe
jlowe reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples/UDF-Examples/RAPIDS-accelerated-UDFs/pom.xml is using RAPIDS Accelerator 24.06 which seems wrong.

examples/ML+DL-Examples/Spark-Rapids-ML/pca/README.md still points to 24.08.
examples/ML+DL-Examples/Spark-Rapids-ML/pca/notebooks/pca.ipynb still points to 24.08.

@nvliyuan
update the versions
1098498 
Signed-off-by: liyuan <[email protected]>
@nvliyuan
Copy link
Collaborator Author

examples/UDF-Examples/RAPIDS-accelerated-UDFs/pom.xml is using RAPIDS Accelerator 24.06 which seems wrong.

examples/ML+DL-Examples/Spark-Rapids-ML/pca/README.md still points to 24.08. examples/ML+DL-Examples/Spark-Rapids-ML/pca/notebooks/pca.ipynb still points to 24.08.

updated, thx

sameerz
sameerz approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@sameerz sameerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for now. I wonder whether we ought to update these pages to point to the minimum requirements at https://nvidia.github.io/spark-rapids/docs/download.html#software-requirements so we do not need to make these changes each time the software versions change.

@nvliyuan
Copy link
Collaborator Author

file #453 , merge this pr.

@nvliyuan nvliyuan merged commit b8e31fd into NVIDIA:branch-24.10 Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameerz sameerz sameerz approved these changes

@jlowe jlowe jlowe approved these changes

@viadea viadea Awaiting requested review from viadea

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu

@SurajAralihalli SurajAralihalli Awaiting requested review from SurajAralihalli

Assignees

@nvliyuan nvliyuan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvliyuan @jlowe @sameerz