Reject container-save arguments with a trailing '/'

See: NVIDIA/enroot#215

Signed-off-by: Felix Abecassis <[email protected]>

args.c

@@ -383,6 +383,11 @@ static int spank_option_container_save(int val, const char *optarg, int remote)
 		return (-1);
 	}
 
+	if (optarg[strlen(optarg) - 1] == '/') {
+		slurm_error("pyxis: --container-save: target is a directory");
+		return (-1);
+	}
+
 	/* Slurm can call us twice with the same value, check if it's a different value than before. */
 	if (pyxis_args.container_save != NULL) {
 		if (strcmp(pyxis_args.container_save, optarg) == 0)

tests/invalid_args.bats

@@ -72,3 +72,14 @@ load ./common
     run_srun_unchecked --container-env FOO, --container-image=ubuntu:22.04 true
     [ "${status}" -ne 0 ]
 }
+
+@test "invalid arg: --container-save=<directory>" {
+    run_srun_unchecked --container-save=/tmp/ --container-image=ubuntu:24.04 true
+    [ "${status}" -ne 0 ]
+
+    run_srun_unchecked --container-save=/ --container-image=ubuntu:24.04 true
+    [ "${status}" -ne 0 ]
+
+    run_srun_unchecked --container-save=./ --container-image=ubuntu:24.04 true
+    [ "${status}" -ne 0 ]
+}