Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the CUDA call that failed in errors. #1335

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/include/cudawrap.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ extern CUmemAllocationHandleType ncclCuMemHandleType;
if( err != CUDA_SUCCESS ) { \
const char *errStr; \
(void) pfn_cuGetErrorString(err, &errStr); \
WARN("Cuda failure %d '%s'", err, errStr); \
WARN("Cuda failure %d '%s' from %s", err, errStr, #cmd); \
return ncclUnhandledCudaError; \
} \
} while(false)
Expand All @@ -40,7 +40,7 @@ extern CUmemAllocationHandleType ncclCuMemHandleType;
if( err != CUDA_SUCCESS ) { \
const char *errStr; \
(void) pfn_cuGetErrorString(err, &errStr); \
WARN("Cuda failure %d '%s'", err, errStr); \
WARN("Cuda failure %d '%s' from %s", err, errStr, #cmd); \
res = ncclUnhandledCudaError; \
goto label; \
} \
Expand All @@ -52,7 +52,7 @@ extern CUmemAllocationHandleType ncclCuMemHandleType;
if( err != CUDA_SUCCESS ) { \
const char *errStr; \
(void) pfn_cuGetErrorString(err, &errStr); \
INFO(NCCL_ALL,"%s:%d Cuda failure %d '%s'", __FILE__, __LINE__, err, errStr); \
INFO(NCCL_ALL,"%s:%d Cuda failure %d '%s' from %s", __FILE__, __LINE__, err, errStr, #cmd); \
} \
} while(false)

Expand Down