-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport to 2.8: Deprecate cub::IterateThreadStore (#3337) #3351
Backport to 2.8: Deprecate cub::IterateThreadStore (#3337) #3351
Conversation
} // namespace detail | ||
|
||
template <int COUNT, int MAX> | ||
using IterateThreadStore CCCL_DEPRECATED = detail::iterate_thread_store<COUNT, MAX>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: what about add a message to say that `IterateThreadStore`` will be removed in the next release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt such a message would help much. If you encounter a deprecation warning during a library upgrade as a user, I think you should move away from using that feature instead of comforting yourself that you still have X units of time left and implement a warning suppression instead.
Also, this is the backport PR so the warning without message went into main
already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also say that the only helpful message would be to suggest a replacement.
Just stating that something is going to be removed is implied by the deprecation
🟩 CI finished in 2h 17m: Pass: 100%/96 | Total: 2d 17h | Avg: 40m 44s | Max: 1h 11m | Hits: 205%/12392
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 96)
# | Runner |
---|---|
71 | linux-amd64-cpu16 |
11 | linux-amd64-gpu-v100-latest-1 |
9 | windows-amd64-cpu16 |
4 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
🟩 CI finished in 1h 40m: Pass: 100%/96 | Total: 2d 17h | Avg: 40m 57s | Max: 1h 15m | Hits: 214%/12392
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 96)
# | Runner |
---|---|
71 | linux-amd64-cpu16 |
11 | linux-amd64-gpu-v100-latest-1 |
9 | windows-amd64-cpu16 |
4 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
No description provided.