Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #3331

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Update CODEOWNERS #3331

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6bfaae
Update CODEOWNERS
jrhemstad Jan 10, 2025
2ba7d2f
Update CODEOWNERS
jrhemstad Jan 13, 2025
8feefb7
Update CODEOWNERS
jrhemstad Jan 13, 2025
0e8ed87
[pre-commit.ci] auto code formatting
pre-commit-ci[bot] Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,29 @@
# general codeowners for all files
# (Order matters. This needs to be at the top)
* @nvidia/cccl-codeowners

# Libraries
thrust/ @nvidia/cccl-thrust-codeowners @nvidia/cccl-codeowners
cub/ @nvidia/cccl-cub-codeowners @nvidia/cccl-codeowners
libcudacxx/ @nvidia/cccl-libcudacxx-codeowners @nvidia/cccl-codeowners
thrust/ @nvidia/cccl-thrust-codeowners
cub/ @nvidia/cccl-cub-codeowners
libcudacxx/ @nvidia/cccl-libcudacxx-codeowners
cudax/ @nvidia/cccl-cudax-codeowners
c/ @nvidia/cccl-c-codeowners
jrhemstad marked this conversation as resolved.
Show resolved Hide resolved
python/ @nvidia/cccl-python-codeowners
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Python team should be a stakeholder here

Suggested change
c/ @nvidia/cccl-c-codeowners
c/ @nvidia/cccl-c-codeowners @nvidia/cccl-python-codeowners

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(alternatively, we could just nuke cccl-c-codeowners...)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree there's a lot of overlap, but I've just encoded that in the membership of the two different groups. Putting two teams listed as codeowners would end up requiring 4 total reviews which is probably too many.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the threshold is set independently in the repo setting, not based on the number of teams? (I could be wrong.)


# Infrastructure
.github/ @nvidia/cccl-infra-codeowners @nvidia/cccl-codeowners
ci/ @nvidia/cccl-infra-codeowners @nvidia/cccl-codeowners
.devcontainer/ @nvidia/cccl-infra-codeowners @nvidia/cccl-codeowners
.github/ @nvidia/cccl-infra-codeowners
ci/ @nvidia/cccl-infra-codeowners
.devcontainer/ @nvidia/cccl-infra-codeowners
.pre-commit-config.yaml @nvidia/cccl-infra-codeowners
.clang-format @nvidia/cccl-infra-codeowners
.clangd @nvidia/cccl-infra-codeowners
c2h/ @nvidia/cccl-infra-codeowners
.vscode @nvidia/cccl-infra-codeowners

# cmake
**/CMakeLists.txt @nvidia/cccl-cmake-codeowners @nvidia/cccl-codeowners
**/cmake/ @nvidia/cccl-cmake-codeowners @nvidia/cccl-codeowners
**/CMakeLists.txt @nvidia/cccl-cmake-codeowners
**/cmake/ @nvidia/cccl-cmake-codeowners

# benchmarks
benchmarks/ @nvidia/cccl-benchmark-codeowners
**/benchmarks @nvidia/cccl-benchmark-codeowners

# docs
docs/ @nvidia/cccl-docs-codeowners
examples/ @nvidia/cccl-docs-codeowners
Loading