Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed poc start command and simulator error message #3157

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fixed poc start command and simulator error message #3157

merged 1 commit into from
Jan 20, 2025

Conversation

yhwen
Copy link
Collaborator

@yhwen yhwen commented Jan 20, 2025

…age.

Fixes # .

Description

  • Fix the simulator run missing server_config in FL context error message due to identify changes.
  • Fix the "nvflare poc start" error.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@chesterxgchen
Copy link
Collaborator

/build

@chesterxgchen chesterxgchen merged commit e130384 into NVIDIA:main Jan 20, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@SYangster SYangster Awaiting requested review from SYangster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhwen @chesterxgchen