Skip to content

Commit

Permalink
Fix TL1_jupyter_plugins test for python 3.7 (#5082)
Browse files Browse the repository at this point in the history
- pin fsspec version to avoid using one from
  https://download.pytorch.org (which doesn't support python 3.7)
- fix protobuf incompatibility by using PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION

Signed-off-by: Janusz Lisiecki <[email protected]>
  • Loading branch information
JanuszL authored and banasraf committed Oct 9, 2023
1 parent 9f667e4 commit 166a2e4
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion qa/TL1_jupyter_plugins/test_pytorch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# used pip packages
# nvidia-index provides a stub for tensorboard which collides with one required by pytorch-lightning
# pin version which is not replaced
pip_packages='pillow jupyter matplotlib<3.5.3 torchvision torch pytorch-lightning tensorboard==2.2.2'
pip_packages='pillow jupyter matplotlib<3.5.3 torchvision torch fsspec==2023.1.0 pytorch-lightning tensorboard==2.2.2'
target_dir=./docs/examples/

do_once() {
Expand All @@ -13,6 +13,7 @@ do_once() {
test_body() {
# dummy
exclude_files="#"
export PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python

# test code
find frameworks/pytorch/ -name "*.ipynb" | sed "/${exclude_files}/d" | xargs -i jupyter nbconvert \
Expand Down

0 comments on commit 166a2e4

Please sign in to comment.