Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross platform command line driver + PropLib template adherence #9

Open
wants to merge 237 commits into
base: dev
Choose a base branch
from
Open

Cross platform command line driver + PropLib template adherence #9

wants to merge 237 commits into from

Conversation

aromanielloNTIA
Copy link
Member

@aromanielloNTIA aromanielloNTIA commented Oct 24, 2024 •
edited
Loading

  • Adds a cross-platform command line driver as a utility for calling the P2108 software library. Inputs are stored in, and outputs are written to, a text file. The command line driver code resides in the app directory, is documented with Doxygen, and has its own README with further information: app/README.md
  • Makes refactoring changes to avoid widespread use of preprocessor directives to hold constants (return codes, tags, and labels)
  • Merges in changes from (NTIA-private) PropLib template repository, such that this repository is up to date with the template. This currently results in some minor and mostly non-functional updates to the files in this repository. In the future, this will allow for upstream changes to the template to be easily and cleanly applied to this repository.

aromanielloNTIA and others added 30 commits September 27, 2024 16:21
@aromanielloNTIA
Initial commit
3c8c6a1
@aromanielloNTIA
Add googletest and doxygen-awesome-css submodules
fc52cc4 
doxygen-awesome-css is checkout out to v2.3.3 tag
@aromanielloNTIA
Add info about merging template changes to downstream
6e77c0b
@aromanielloNTIA
Update doxygen-awesome-css to v2.3.4
23b21f8
@aromanielloNTIA
Merge pull request #1 from NTIA/doxygen-awesome-css-v2.3.4
b65ec43 
Update doxygen-awesome-css to v2.3.4
@aromanielloNTIA
Update examples to recommend constexpr instead of macros
a258519
@aromanielloNTIA
Merge pull request #2 from NTIA/avoid-macros-as-constants
26fd183 
Update examples to recommend constexpr instead of macros
@aromanielloNTIA
Merge pull request #3 from NTIA/dev
cd1a20a 
Merge recent updates
@aromanielloNTIA
Merge remote-tracking branch 'proplib-template/main' into inherit-fro…
adbaf9b 
…m-template
@aromanielloNTIA
Delete CREATING-REPOSITORIES.md
2d8a04d 
Moved contents to GitHub wiki
@aromanielloNTIA
Merge remote-tracking branch 'proplib-template/main' into inherit-fro…
2359c72 
…m-template
@aromanielloNTIA
Add CLI app to cmake configuration
f1f34aa
@aromanielloNTIA
Update CLI app readme for templating
674e808
@aromanielloNTIA
Initial add CLI app
04b396a
@aromanielloNTIA
Merge remote-tracking branch 'proplib-template/main' into cross-platf…
e7f83e5 
…orm-cli-driver
@aromanielloNTIA
Fix function names
ce84c79
@aromanielloNTIA
Add P2108 functions to driver header
b479311
@aromanielloNTIA
finish driver functionality, add outputs
3656d00
@aromanielloNTIA
make GetDatetimeString thread-safe across platforms
bc6c924
@aromanielloNTIA
Merge remote-tracking branch 'proplib-template/main' into cross-platf…
c1f8c20 
…orm-cli-driver
@aromanielloNTIA
move functions to utils
4469140
@aromanielloNTIA
Add driver testing configuration
aa4257a
@aromanielloNTIA
modernize driver utility functions
48d3c6d 
use strings, avoid pointers, fix a typo in Version output
@aromanielloNTIA
const correct driver util functions
5b23eb6
@aromanielloNTIA
rename Utils to DriverUtils
c333e6e
@aromanielloNTIA
Add simple tests for parsing functions
4dae8a6
@aromanielloNTIA
Merge remote-tracking branch 'proplib-template/main' into cross-platf…
0a2c7f7 
…orm-cli-driver
@aromanielloNTIA
pragma once in driver
40b16c7
@aromanielloNTIA
avoid duplicate googletest init
571078c
@aromanielloNTIA
Avoid duplicate googletest init
df9f3a1
@aromanielloNTIA
Merge remote-tracking branch 'proplib-template/main' into cross-platf…
0a0248e 
…orm-cli-driver
@aromanielloNTIA
.gitignore binaries in wrappers
496fba6
@aromanielloNTIA
Organize includes
df2c0ef
@aromanielloNTIA
Merge remote-tracking branch 'proplib-template/main' into cross-platf…
0ac7963 
…orm-cli-driver
@aromanielloNTIA
Add missing include
fd28e1a
@aromanielloNTIA
ignore derived files from wrappers
cc867b1
@aromanielloNTIA
Merge remote-tracking branch 'proplib-template/main' into cross-platf…
a11298e 
…orm-cli-driver
@aromanielloNTIA
fix template code so tests all pass
649203b
@aromanielloNTIA
Run actions on template
9d98550
@aromanielloNTIA
remove template condition
2f55d04
@aromanielloNTIA
build docs on push to main or dev
07484c3
@aromanielloNTIA
cleanup includes
d4146b5
@aromanielloNTIA
Merge remote-tracking branch 'proplib-template/main' into cross-platf…
eb05d93 
…orm-cli-driver
@aromanielloNTIA
Update badges, add links to other template repos
3624162
@aromanielloNTIA
Merge remote-tracking branch 'proplib-template/main' into cross-platf…
289ad28 
…orm-cli-driver
@aromanielloNTIA
update DOI and citation metadata
dba1216
@aromanielloNTIA
Add template citation file
f4f7ba0
@aromanielloNTIA
Add template zenodo file
fb9f130
@aromanielloNTIA
Merge remote-tracking branch 'proplib-template/main' into cross-platf…
3f60ff9 
…orm-cli-driver
@aromanielloNTIA
Put platform name in driver filename
7829fae
@aromanielloNTIA
Update release action for cross platform driver
587fc5a
@aromanielloNTIA
Don't build docs in ctest action
b283c36
@aromanielloNTIA
Don't clone unnecessary submodule
6505dca
@aromanielloNTIA
Fix windows step condition
26320fe
@aromanielloNTIA
Merge remote-tracking branch 'proplib-template/main' into cross-platf…
352cf6f 
…orm-cli-driver
blainNTIA
blainNTIA approved these changes Nov 13, 2024
View reviewed changes
Copy link

@blainNTIA blainNTIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

app/tests/TestDriver.h Show resolved Hide resolved
app/include/ReturnCodes.h Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blainNTIA blainNTIA blainNTIA approved these changes

Assignees

@aromanielloNTIA aromanielloNTIA

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aromanielloNTIA @blainNTIA