Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr cmake #8

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Pr cmake #8

wants to merge 18 commits into from

Conversation

dirkcgrunwald
Copy link

  1. Add build multi-platform build support using cmake
  2. perform builds using github actions
  3. Fix minor Windows / C++ incompatibilities (intermixing wchar/char output)

@JayKickliter
Copy link

JayKickliter commented Nov 9, 2023

I cloned this PR and did my normal CMake based build steps and it built just fine. I didn't have to read any build instructions and there weren't any surprises. Built on macOS+M1.

@JayKickliter
Copy link

I've created rust wrapper for this branch and we're using it in production at decent scale. I'd love to see this work merged, otherwise there's a decent chance of having long-lived forks people depend on.

@wkozmaNTIA
Copy link
Member

We're going through some internal reorganization with the larger PropLib effort over this winter, which will include work being done in this branch. Sorry its taken longer than it probably should. Just how things are being prioritized.

@dirkcgrunwald
Copy link
Author

dirkcgrunwald commented Nov 15, 2023

I'm happy to help however I can. Good to know the patch has been useful.

@JayKickliter - I'd be interested in learning about the project you're doing. Looking at the HexTree and geoprop repos, it looks like you're developing something that I had been hoping to work on within NSF SpectrumX similar to what e.g. https://cloudrf.com/ does but in a way that can support open datasets and new prop models.

Email is [email protected]

@JayKickliter
Copy link

@dirkcgrunwald you nailed what we're doing. I'll follow up with an email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants