Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline run fixes #450

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Pipeline run fixes #450

merged 5 commits into from
Jan 22, 2025

Conversation

martin-springer
Copy link
Collaborator

@martin-springer martin-springer commented Jan 15, 2025

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@martin-springer martin-springer marked this pull request as ready for review January 15, 2025 20:28
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.17%. Comparing base (bd86075) to head (924bdb3).

Files with missing lines Patch % Lines
rdtools/analysis_chains.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #450      +/-   ##
===============================================
- Coverage        96.21%   96.17%   -0.05%     
===============================================
  Files               12       12              
  Lines             2274     2276       +2     
===============================================
+ Hits              2188     2189       +1     
- Misses              86       87       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mdeceglie mdeceglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @martin-springer

@mdeceglie mdeceglie merged commit c98ec09 into development Jan 22, 2025
19 checks passed
@mdeceglie mdeceglie deleted the pipeline_run_fixes branch January 22, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants