Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #313 (different results with Nan's and Zeros in power series) #442

Merged
merged 22 commits into from
Dec 30, 2024

Conversation

martin-springer
Copy link
Collaborator

@martin-springer martin-springer commented Dec 11, 2024

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (c59708a) to head (2338d92).

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #442      +/-   ##
===============================================
+ Coverage        96.17%   96.21%   +0.03%     
===============================================
  Files               11       12       +1     
  Lines             2251     2270      +19     
===============================================
+ Hits              2165     2184      +19     
  Misses              86       86              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mdeceglie mdeceglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I suggest we make a minor change to the docstrings to remind us and users about the x≥0 assumption

rdtools/utilities.py Outdated Show resolved Hide resolved
rdtools/utilities.py Outdated Show resolved Hide resolved
rdtools/utilities.py Outdated Show resolved Hide resolved
martin-springer and others added 3 commits December 30, 2024 15:08
Co-authored-by: Michael Deceglie <[email protected]>
Co-authored-by: Michael Deceglie <[email protected]>
Co-authored-by: Michael Deceglie <[email protected]>
@martin-springer
Copy link
Collaborator Author

Looks good. I suggest we make a minor change to the docstrings to remind us and users about the x≥0 assumption

@mdeceglie - Yes, that sounds good to me. I committed your additions.

@mdeceglie mdeceglie merged commit 9903aaa into development Dec 30, 2024
19 checks passed
@mdeceglie mdeceglie deleted the fix_issue_#313 branch December 30, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants