-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #313 (different results with Nan's and Zeros in power series) #442
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #442 +/- ##
===============================================
+ Coverage 96.17% 96.21% +0.03%
===============================================
Files 11 12 +1
Lines 2251 2270 +19
===============================================
+ Hits 2165 2184 +19
Misses 86 86 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I suggest we make a minor change to the docstrings to remind us and users about the x≥0 assumption
Co-authored-by: Michael Deceglie <[email protected]>
Co-authored-by: Michael Deceglie <[email protected]>
Co-authored-by: Michael Deceglie <[email protected]>
@mdeceglie - Yes, that sounds good to me. I committed your additions. |
New functions added to__init__.py
API.rst is up to date, along with other sphinx docs pagesExample notebooks are rerun and differences in results scrutinized