Shree changes #18
Open
Shree changes #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. features : incoporates the functions for bond and atom features from xtb 3. preprocessor: function call to incule a json file if it is passed from xtb calculations.
…atures : incoporates the functions for bond and atom features from xtb 3. preprocessor: function call to incule a json file if it is passed from xtb calculations.
…into shree_changes
2. minor correction to features and xtb_preprocessing
2. Example showing the the diffrent features 3. added in tests (dont know how to check them though :/)
2. addressing all other comments
Updated the xtb inputs as well
…into shree_changes
checks for the numpy array global feature and that the padding and batching operations work. Probably could have more informative features in the batching test, but this works for now
…'shree_changes' of https://github.com/shreesowndarya/nfp into shree_changes
1. preprocessing 2. building a model fro YSI prediction Adding innecessary data of json files for model building Some updates to xtb_preprocessor to incoporate bond_indices as well.
|
Hey Shree, Is there any way we could demo this without adding ~200 new json files to this repository? Im wondering if you could just download them from another source in the demo notebook. This package gets used in a few other places, so it might be a pain to have to download those even when we're not doing anything with xtb. |
|
Is it ok to have it as a zipped folder instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in example with xtb json
Adding in necessary JSON files for YSI prediction
Updates to xtb_preprocessor.py to incorporate bond_indices