fix: Add correct representation of Value curves and remove name from cost and function data components #45

pesap · 2024-09-20T19:46:40Z

List of changes

Remove name from value_curves and cost functions,
Add new wrapper function for InputOutputCurve called LinearCurve,
Removed units field from TimeSeriesData,
Changed logic of how data is handled if pint.Quantity or BaseQuantity is passed,
Updated testing to check that data is the same instead of checking same instance,
Update fields from cost functions,

codecov-commenter · 2024-09-25T16:30:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.43%. Comparing base (9dc0e3e) to head (9d9d5ea).

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   95.40%   95.43%   +0.03%     
==========================================
  Files          33       33              
  Lines        2719     2741      +22     
==========================================
+ Hits         2594     2616      +22     
  Misses        125      125

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

behaviour. List of changes - Changed data handling when we create an instance of `SingleTimeSeries`. - Updated test to check that data inside a `SingleTimeSeries` is consistent since it could return two different instances when serialize and deserialize. - Updated arrow storage to convert to `pa.Array` when serializing only and better type hint

src/infrasys/time_series_models.py

src/infrasys/function_data.py

src/infrasys/arrow_storage.py

src/infrasys/cost_curves.py

tests/test_system.py

…cost and function data components (#45) List of changes - Changed data handling when we create an instance of `SingleTimeSeries`. - Updated test to check that data inside a `SingleTimeSeries` is consistent since it could return two different instances when serialize and deserialize. - Updated arrow storage to convert to `pa.Array` when serializing only and better type hint

pesap added 2 commits September 18, 2024 23:54

fix: Added correct names for the Fuel Curves

dd7dbed

fix: Removing name from cost curves and function data

9c35e68

pesap added the bug Something isn't working label Sep 20, 2024

pesap self-assigned this Sep 20, 2024

fix: Updating test to match new fields.

763162b

pesap requested a review from daniel-thom October 4, 2024 23:21

daniel-thom approved these changes Oct 8, 2024

View reviewed changes

pesap added 3 commits October 18, 2024 01:24

fix: Removed logic that creates a pa.array right away.

2ba8324

test: Add testing for new function

70e5988

pesap requested a review from daniel-thom October 21, 2024 21:52

daniel-thom reviewed Oct 21, 2024

View reviewed changes

pesap added 3 commits October 21, 2024 18:09

test: Adding more sanity test

aa1d94a

fixup! test: Adding more sanity test

1a5a80e

bumpversion

9d9d5ea

pesap merged commit ae517df into main Oct 22, 2024
6 checks passed

pesap deleted the ps/value_curves branch October 22, 2024 01:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add correct representation of Value curves and remove name from cost and function data components #45

fix: Add correct representation of Value curves and remove name from cost and function data components #45

pesap commented Sep 20, 2024 •

edited

Loading

codecov-commenter commented Sep 25, 2024 •

edited

Loading

fix: Add correct representation of Value curves and remove name from cost and function data components #45

fix: Add correct representation of Value curves and remove name from cost and function data components #45

Conversation

pesap commented Sep 20, 2024 • edited Loading

codecov-commenter commented Sep 25, 2024 • edited Loading

Codecov Report

pesap commented Sep 20, 2024 •

edited

Loading

codecov-commenter commented Sep 25, 2024 •

edited

Loading