fix(base_quantity): Removed string return from serialization of pint quantity. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantity. List of changes: - Removed str(input_value.magnitude) to return a proper number instead of a string when calling `.model_dump()` - Added a specific serialization option when calling `.model_dump(mode="json")` or `.model_dump_json()` to return a string version of the field. This is only import for pint quantities, such that it returns something like `10 kV` that is easily deserialized with pint, - Added better type check for instances of the BaseQuantity used on the pydantic model, - Relaxed the schema serialization since pint will handle most of it, - Added better typehint for pydantic classmethods
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 95.88% 96.02% +0.14%
==========================================
Files 25 25
Lines 2165 2166 +1
==========================================
+ Hits 2076 2080 +4
+ Misses 89 86 -3 ☔ View full report in Codecov by Sentry. |
daniel-thom
reviewed
Jun 3, 2024
|
@daniel-thom This is ready to re-review. |
daniel-thom
approved these changes
Jun 5, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
…quantity. (#28) List of changes: - Removed str(input_value.magnitude) to return a proper number instead of a string when calling `.model_dump()` - Added a specific serialization option when calling `.model_dump(mode="json")` or `.model_dump_json()` to return a string version of the field. This is only import for pint quantities, such that it returns something like `10 kV` that is easily deserialized with pint, - Added better type check for instances of the BaseQuantity used on the pydantic model, - Relaxed the schema serialization since pint will handle most of it, - Added better typehint for pydantic classmethods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes:
str(input_value.magnitude)to return a proper number instead of a string when calling.model_dump().model_dump(mode="json")or.model_dump_json()to return a string version of the field. This is only import for pint quantities, such that it returns something like10 kVthat is easily deserialized with pint,