Fixed error of pint from previous commit and added new functionality #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions List of changes: - Removed `__new__` from BaseQuantity - Added `ureg.check` to default units. This will check if the unit is compatible, but will not check the input value. - Added testing for BaseQuantity class and units. Issue #24
…that are not classes.
BaseQuantity.
List of changes:
- Fixed an issue where if we passes a BaseQuantiy it will try to
override it and remove its units. Now, it just return the Class
itself,
- Added new functionallity to pass any float or int and will convert it
to the unit that was specificed on the Field. This requires
__base__unit__ to exists.
- Added better serialization where we can pass custom dictionary to
change the serialization of a pint.Quantity. By default, it return a
string of the quantity (e.g. '10 volt'), but now if we just want to
export the magnitude we pass
`.model_dump(context={"magnitude_only":True})` will return '10'
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 95.44% 95.88% +0.44%
==========================================
Files 25 25
Lines 2131 2165 +34
==========================================
+ Hits 2034 2076 +42
+ Misses 97 89 -8 ☔ View full report in Codecov by Sentry. |
daniel-thom
reviewed
May 25, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 29, 2024
…ctionality (#26) List of changes: - Fixed an issue where if we passes a BaseQuantiy it will try to override it and remove its units. Now, it just return the Class itself, - Added new functionallity to pass any float or int and will convert it to the unit that was specificed on the Field. This requires __base__unit__ to exists. - Added better serialization where we can pass custom dictionary to change the serialization of a pint.Quantity. By default, it return a string of the quantity (e.g. '10 volt'), but now if we just want to export the magnitude we pass `.model_dump(context={"magnitude_only":True})` will return '10'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
override it and remove its units. Now, it just return the Class
itself,
to the unit that was specificed on the Field. This requires
base__unit to exists.
change the serialization of a pint.Quantity. By default, it return a
string of the quantity (e.g. '10 volt'), but now if we just want to
export the magnitude we pass
.model_dump(context={"magnitude_only":True})will return '10'