Add AtomsBase conversions #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some convenient functions for converting to and from the standard AtomsBase systems. A tighter integration with the AtomsBase interface is currently incompatible with our handling of initial distributions and launching simulations such that the larger changes would be required.
For now, this will make it easier to use things like AtomsIO and potentially facilitate other features in the future. I plan to add a section about these features to main documentation. I considered deprecating some of the existing IO features using ASE and ExtXYZ but have decided to leave them for now. However, I believe these new conversions will be the better option moving forward.