Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unsafe options from content security policy; refs Github #392 #395

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

HankHerr-NOAA
Copy link
Contributor

Description

[Short description explaining the high-level reason for the pull request]

Changes Made

Testing

Related Tickets

  • Fixes [Ticket number]

Checklists

Deployment Plan (For developer use)

How does the changes affect the product?

  • Feature addition
  • Bug fix
  • Database change

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • The feature branch you're submitting as a PR is up to date
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • No Placeholder code
  • Reviewers requested
  • Add yourself as an assignee in the PR

Merge Checklist (For Technical Lead use only)

  • If applicable, update README with major alterations

@HankHerr-NOAA
Copy link
Contributor Author

I'm closing this pull request, because the change results in a badly formatted front-end API. Specifically, the text area is tiny and does not display the entire smoke test. Ugly.

Further changes are needed, so no need to merge now.

Hank

@HankHerr-NOAA HankHerr-NOAA merged commit e8e123a into master Feb 3, 2025
6 checks passed
@HankHerr-NOAA HankHerr-NOAA deleted the github392_3 branch February 3, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant