Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the vendored version of the cfe submodule. Several additions and changes are introduced in this update. To the best of my abilities, these additions and changes are listed below.
Note, with this update,
extern/cfe/CMakeList.txt
is now out of date and will not build all portions of cfe. Before merging this PR, theCMakeList
inextern/cfe
either needs to be updated or removed. In the mean time, the latest version ofcfe
can be built (from the root of thengen
repo) using:Additions
SOIL_TO_GW_FLUX
(percolation) added (added_new_bmi_output_variable cfe#92).Changes
ice_fraction_xinan
is now namedice_fraction_xinanjiang
(changed_bmi_name cfe#94).char
overflow inread_file_line_counts
fixed (fix potential overflow that can lead to infinite loop in file reading cfe#85).Todos
/ removeextern/cfe/CMakeList.txt
Notes:
Checklist