Code

Bmi_Adapter cleanup, de-template#646

Code

Merged

PhilMiller merged 11 commits intoNOAA-OWP:masterNOAA-OWP/ngen:masterfrom PhilMiller:bmi-adapter-cleanupPhilMiller/NOAA-OWP-ngen:bmi-adapter-cleanupCopy head branch name to clipboardNov 13, 2023

+48-84

Commits

Commits on Nov 7, 2023

• Replace written-out default copy/move constructors with compiler-generated

  PhilMiller

  committed
  c0cf707

  Copy full SHA for c0cf707

• Bugfix: correct mis-typed copy constructor argument

  PhilMiller

  committed
  b92feb4

  Copy full SHA for b92feb4

• Refactor: Move bmi_model pointer down to obviate template usage

  PhilMiller

  committed
  210cb06

  Copy full SHA for 210cb06

• Refactor: de-template class Bmi_Adapter

  PhilMiller

  committed
  47e0466

  Copy full SHA for 47e0466

• Delete copy constructor that should never be called

  PhilMiller

  committed
  ee072f3

  Copy full SHA for ee072f3

• Enhance exception message

  PhilMiller

  committed
  8707e5c

  Copy full SHA for 8707e5c

Commits on Nov 8, 2023

• Bmi_Cpp_Adapter: delete pointless static model_name variable

  PhilMiller

  committed
  7fdb3a7

  Copy full SHA for 7fdb3a7

• AbstractCLibBmiAdapter: Move bmi_model member down to leaf classes, since their handling of lifecycle is disparate

  PhilMiller

  committed
  9322eb6

  Copy full SHA for 9322eb6

• Bmi_*_Adapter: make them non-copyable and non-movable

  PhilMiller

  committed
  32824d6

  Copy full SHA for 32824d6

• AbstractCLibBmiAdapter: De-template since the bmi_model member is moved down

  PhilMiller

  committed
  6ac2685

  Copy full SHA for 6ac2685

• Convert bmi_model members from shared_ptr to unique_ptr

  Show description for 1e0ab7d
  PhilMiller

  committed
  1e0ab7d

  Copy full SHA for 1e0ab7d